New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 633022 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Enable multi-sampling on floating-point color renderbuffers

Project Member Reported by jie.a.c...@intel.com, Aug 1 2016

Issue description

According to the WebGL EXT_color_buffer_float Extension -- 
"Multi-sample floating-point color renderbuffers may optionally be supported. Applications must follow the limitations defined in the EXT_color_buffer_float extension, and check for framebuffer completeness after attaching such a renderbuffer.", so we now need to relax it in chromium appropriately.

More information can be found below:
https://github.com/KhronosGroup/WebGL/pull/1935
https://github.com/KhronosGroup/WebGL/issues/1936
https://github.com/KhronosGroup/WebGL/pull/1789
https://github.com/KhronosGroup/WebGL/pull/1946
 
Cc: yunchao...@intel.com
Labels: TE-NeedsfurtherTriage
Cc: zmo@chromium.org kbr@chromium.org
Components: Internals>GPU

Comment 5 by kbr@chromium.org, Aug 1 2016

Components: Blink>WebGL
Labels: -OS-Linux -Pri-3 OS-All Pri-2

Comment 6 by kbr@chromium.org, Aug 1 2016

Labels: -TE-NeedsfurtherTriage

Comment 7 by kbr@chromium.org, Aug 1 2016

Status: Available (was: Unconfirmed)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b81471dd97cd4f1b4803edfa3030112122a0feec

commit b81471dd97cd4f1b4803edfa3030112122a0feec
Author: jie.a.chen <jie.a.chen@intel.com>
Date: Wed Aug 03 06:53:42 2016

Relax multi-sampling for floating-point color renderbuffers

It's now optionally allowed to multi-sample the renderbuffers of float-point
color using Ext_color_buffer_float extension against WebGL2. This CL simply
relaxes it.

BUG= 633022 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2197893003
Cr-Commit-Position: refs/heads/master@{#409473}

[modify] https://crrev.com/b81471dd97cd4f1b4803edfa3030112122a0feec/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/b81471dd97cd4f1b4803edfa3030112122a0feec/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87e7b15fcce7cf416d138c7a5edf4f3e5b676c1a

commit 87e7b15fcce7cf416d138c7a5edf4f3e5b676c1a
Author: sunnyps <sunnyps@chromium.org>
Date: Thu Aug 11 23:52:35 2016

Suppress WebGL2 EXT_color_buffer_float test failure on Linux ATI.

This is causing repeated test failures e.g.
https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28ATI%29/builds/48840

R=kbr@chromium.org, geofflang@chromium.org
BUG= 633022 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2241613002
Cr-Commit-Position: refs/heads/master@{#411454}

[modify] https://crrev.com/87e7b15fcce7cf416d138c7a5edf4f3e5b676c1a/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a2fbf7da5f90804ae03f0634248639cf22330ad

commit 3a2fbf7da5f90804ae03f0634248639cf22330ad
Author: zmo <zmo@chromium.org>
Date: Thu Aug 25 18:42:17 2016

Fix getInternalformativ on GL 4.1 or lower.

BUG= 633022 
TEST=webgl2_conformance
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2278823002
Cr-Commit-Position: refs/heads/master@{#414488}

[modify] https://crrev.com/3a2fbf7da5f90804ae03f0634248639cf22330ad/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/3a2fbf7da5f90804ae03f0634248639cf22330ad/gpu/command_buffer/service/gles2_cmd_decoder.cc

Comment 11 by kbr@chromium.org, Aug 31 2016

Owner: jie.a.c...@intel.com
Status: Started (was: Available)
This is in progress -- Jie, may I assign this to you to make sure all the pieces are in place and the tests are passing?

Comment 12 by kbr@chromium.org, Sep 1 2016

Cc: geoffl...@chromium.org jmad...@chromium.org qiankun....@intel.com
 Issue 636482  has been merged into this issue.
Sure, I will take care of it!
Status: Fixed (was: Started)

Sign in to add a comment