New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 633021 link

Starred by 4 users
Status: Fixed
Owner:
alancutter@chromium.org
Closed: Aug 2016
Cc:
█ dstockwell@chromium.org
e...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Transform animations on <img> elements don't get composited

Project Member Reported by alancutter@chromium.org, Aug 1 2016 
Test: https://jsfiddle.net/ups4x5sk/

Most likely regressed in:
https://codereview.chromium.org/1423893002

This bug is due to an inconsistency between layout's and animation's idea of what can and cannot be transformed. The logic in layout should be exposed to animations e.g. layoutObject()->canTransform() to avoid such mismatches.

Comment 1 by alancutter@chromium.org, Aug 1 2016

Cc: e...@chromium.org
+eae: Do you know where layout decides whether CSS transforms take effect on an element?

Comment 2 by suzyh@chromium.org, Aug 2 2016

Labels: Update-Fortnightly
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc4a00b29ecc52a9eb29ceb433101c4075a5d84f

commit dc4a00b29ecc52a9eb29ceb433101c4075a5d84f
Author: alancutter <alancutter@chromium.org>
Date: Wed Aug 10 06:54:53 2016

Update logic in animations for deciding whether an element can transform

This change makes CompositorAnimations.cpp more closely match the logic
used in paint code for deciding whether an element's used transform
is not none.

BUG= 633021 

Review-Url: https://codereview.chromium.org/2225743002
Cr-Commit-Position: refs/heads/master@{#410987}

[add] https://crrev.com/dc4a00b29ecc52a9eb29ceb433101c4075a5d84f/third_party/WebKit/LayoutTests/virtual/threaded/animations/img-element-transform.html
[modify] https://crrev.com/dc4a00b29ecc52a9eb29ceb433101c4075a5d84f/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
[modify] https://crrev.com/dc4a00b29ecc52a9eb29ceb433101c4075a5d84f/third_party/WebKit/Source/core/layout/LayoutObject.h

Comment 5 by alancutter@chromium.org, Aug 11 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment