Arc enabled preference should not be synced |
||||
Issue descriptionSyncing arc.enabled across devices could cause unexpected data loss and should not happen. See b/30130436 for more discussion.
,
Aug 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47c3d35e31beabc6f54bd10b3efe188978caae6e commit 47c3d35e31beabc6f54bd10b3efe188978caae6e Author: khmel <khmel@chromium.org> Date: Thu Aug 04 20:37:27 2016 Revert of Make the ARC opt-in preference not synced. (patchset #1 id:1 of https://codereview.chromium.org/2198733002/ ) Reason for revert: This introduces UI regression (Arc start notification is shown on each device on each update). Also this breaks UMA statistics. Original issue's description: > Make the ARC opt-in preference not synced. > > If we sync the ARC opt-in prefence we may cause unintentional data loss > when the user opts-out of ARC on one device. > > BUG= 633017 > TEST=Manually test by opting out of ARC on one machine and observing a > second (opted-in) machine's state. > > Committed: https://crrev.com/1c7841e8e0322b8c3599710e017ff0fb38ab056f > Cr-Commit-Position: refs/heads/master@{#408909} TBR=hidehiko@chromium.org,dspaid@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 633017 Review-Url: https://codereview.chromium.org/2215943002 Cr-Commit-Position: refs/heads/master@{#409891} [modify] https://crrev.com/47c3d35e31beabc6f54bd10b3efe188978caae6e/chrome/browser/chromeos/arc/arc_auth_service.cc
,
Aug 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/176f6733ab5bdf6de91f08e840b814cf76b910bb commit 176f6733ab5bdf6de91f08e840b814cf76b910bb Author: dspaid <dspaid@chromium.org> Date: Wed Aug 10 07:29:14 2016 Do not sync the ARC++ opt-in preference. This is a re-implementation of 1c7841e8e0322b8c3599710e017ff0fb38ab056f, which made ARC opt-in preference not synced. That change also stopped sending UMA stats due to not calling the OnSyncedPrefChanged method. BUG= 633017 TEST=browser_tests --gtest_filter=ArcAuthServiceTest.* Additionally manually tested that the normal opt-in/opt-out process worked as expected. Review-Url: https://codereview.chromium.org/2206883002 Cr-Commit-Position: refs/heads/master@{#410994} [modify] https://crrev.com/176f6733ab5bdf6de91f08e840b814cf76b910bb/chrome/browser/chromeos/arc/arc_auth_service.cc
,
Aug 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/176f6733ab5bdf6de91f08e840b814cf76b910bb commit 176f6733ab5bdf6de91f08e840b814cf76b910bb Author: dspaid <dspaid@chromium.org> Date: Wed Aug 10 07:29:14 2016 Do not sync the ARC++ opt-in preference. This is a re-implementation of 1c7841e8e0322b8c3599710e017ff0fb38ab056f, which made ARC opt-in preference not synced. That change also stopped sending UMA stats due to not calling the OnSyncedPrefChanged method. BUG= 633017 TEST=browser_tests --gtest_filter=ArcAuthServiceTest.* Additionally manually tested that the normal opt-in/opt-out process worked as expected. Review-Url: https://codereview.chromium.org/2206883002 Cr-Commit-Position: refs/heads/master@{#410994} [modify] https://crrev.com/176f6733ab5bdf6de91f08e840b814cf76b910bb/chrome/browser/chromeos/arc/arc_auth_service.cc
,
Aug 12 2016
,
Aug 12 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4c42540ffb0052ca31f9ca429920c95fba10b3d commit d4c42540ffb0052ca31f9ca429920c95fba10b3d Author: dspaid <dspaid@chromium.org> Date: Sun Aug 14 23:03:01 2016 Do not sync the ARC++ opt-in preference. This is a re-implementation of 1c7841e8e0322b8c3599710e017ff0fb38ab056f, which made ARC opt-in preference not synced. That change also stopped sending UMA stats due to not calling the OnSyncedPrefChanged method. BUG= 633017 TEST=browser_tests --gtest_filter=ArcAuthServiceTest.* Additionally manually tested that the normal opt-in/opt-out process worked as expected. NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2206883002 Cr-Commit-Position: refs/heads/master@{#410994} (cherry picked from commit 176f6733ab5bdf6de91f08e840b814cf76b910bb) Review-Url: https://codereview.chromium.org/2235313003 Cr-Commit-Position: refs/branch-heads/2785@{#583} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/d4c42540ffb0052ca31f9ca429920c95fba10b3d/chrome/browser/chromeos/arc/arc_auth_service.cc
,
Mar 28 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Aug 1 2016