Issue metadata
Sign in to add a comment
|
Bookmarks Bar Folders Are Black/Grey
Reported by
dave197...@gmail.com,
Aug 1 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.82 Safari/537.36 Steps to reproduce the problem: 1. Create a new folder in the bookmarks bar. 2. Look at existing folders if you have them, they are now black/grey. 3. What is the expected behavior? The folders on the bookmarks bar should be yellow or the same color on the latest stable Version 52.0.2743.82 m What went wrong? Updating to the beta build 53.0.2785.34 Did this work before? Yes Version 52.0.2743.82 m Chrome version: 53.0.2785.34 Channel: beta OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 22.0 r0
,
Aug 3 2016
Thanks for the report. CL: https://chromium.googlesource.com/chromium/src/+log/59d51f9a4cea0fd3d0c27eaf069442b9f556ea9a..d1b22fc961b1a2677c32f61a2a5640850b66adb9 might be related to md-settings, https://chromium.googlesource.com/chromium/src/+/2676e97c1a42b7898fbc09176ab94b59bf1c421d pkasting@, could you please check and help. Note: 1. Good Build: 53.0.2748.0 Bad Build: 53.0.2750.0 2. Able to reproduce the issue on Win7 using Chrome Beta 53.0.2785.34, Dev 54.0.2816.0 and Canary 54.0.2817.0; but in Stable 52.0.2743.82 it is showing yellow(normal) icon for bookmark folders. 3. Seeing the grey/shaded bookmarks folders in Mac OSX 10.11.6 & Ubuntu 14.04 using Stable # 52.0.2743.82 (attached screenshot for reference)
,
Aug 3 2016
I think the solid-black icons on Windows look bad, but Evan is the one who vectorized these and knows what the design intent was/how much we've implemented that design.
,
Aug 4 2016
Oops, this is something we need to fix. Luckily it's a ~1 liner: we just need to remove the MD check here: https://cs.chromium.org/chromium/src/chrome/browser/ui/bookmarks/bookmark_utils.cc?rcl=1470295099&l=289 We want to keep the icons yellow on Windows. There was vociferous push back when we turned them grey before. In the long run we want to vectorize them (see bug 564112), but leaving the old yellow pngs in place for now is preferable to having them be grey like on cros.
,
Aug 4 2016
,
Aug 5 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/055a5526ac6933493707b6c9698d739ab56fb7b1 commit 055a5526ac6933493707b6c9698d739ab56fb7b1 Author: estade <estade@chromium.org> Date: Fri Aug 05 21:45:24 2016 Stick with old yellow bookmark folder icons on Windows, even in MD. BUG= 633013 Review-Url: https://codereview.chromium.org/2210993002 Cr-Commit-Position: refs/heads/master@{#410171} [modify] https://crrev.com/055a5526ac6933493707b6c9698d739ab56fb7b1/chrome/browser/ui/bookmarks/bookmark_utils.cc
,
Aug 5 2016
,
Aug 6 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/09b66b79a64e9fe7a4918fa0d4c4b91363de37c6 commit 09b66b79a64e9fe7a4918fa0d4c4b91363de37c6 Author: Evan Stade <estade@chromium.org> Date: Mon Aug 08 16:15:17 2016 Stick with old yellow bookmark folder icons on Windows, even in MD. BUG= 633013 Review-Url: https://codereview.chromium.org/2210993002 Cr-Commit-Position: refs/heads/master@{#410171} (cherry picked from commit 055a5526ac6933493707b6c9698d739ab56fb7b1) Review URL: https://codereview.chromium.org/2227503004 . Cr-Commit-Position: refs/branch-heads/2785@{#526} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/09b66b79a64e9fe7a4918fa0d4c4b91363de37c6/chrome/browser/ui/bookmarks/bookmark_utils.cc
,
Aug 9 2016
this is verified because they filed a bug here: bug 635389 (which is WAI)
,
Aug 9 2016
Issue 635949 has been merged into this issue.
,
Aug 10 2016
Verified the issue from Chrome-TE end on Windows 10 using chrome latest Beta M53-53.0.2785.57 and observed no issues while creating new bookmark folder on the bookmark bar. Hence adding TE-Verified label. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by digitalt...@gmail.com
, Aug 1 2016