New issue
Advanced search Search tips

Issue 633012 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug

Blocking:
issue 674797



Sign in to add a comment

Markers on <polygon> not oriented correctly

Reported by michael....@gmail.com, Jul 31 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36

Example URL:
http://codepen.io/mullany/pen/pbkqLB/

Steps to reproduce the problem:
1. Create a polygon 
2. Define a marker with orient=auto
3. Apply the marker with marker-start and marker-end

What is the expected behavior?
Markers at the start and end of the polygon should be oriented perpendicular to the bisect of the angle between the first and last polygon segments

What went wrong?
Both marker start and marker end are oriented perpendicular to the starting segment. Attached are the correct behavior from Firefox and Chrome's incorrect behavior. 

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? Yes 

Chrome version: 51.0.2704.103  Channel: n/a
OS Version: 10.0
Flash Version: 

Works in Firefox and Edge correctly (haven't checked safari)
 
marker example 4.PNG
11.2 KB View Download
bad chrome markers on polygon.PNG
2.6 KB View Download
Actually, the last marker-mid isn't applied correctly either. Just noticed that when I changed the marker-mid from a circle to an ellipse. 
bad chrome - last marker mid on polygon.PNG
2.4 KB View Download

Comment 2 by kojii@chromium.org, Aug 1 2016

Components: -Blink Blink>SVG
Labels: -OS-Windows OS-All
Status: Untriaged (was: Unconfirmed)
Owner: schenney@chromium.org
Status: Available (was: Untriaged)
Might be a Skia problem, but I think we orient and draw the markers. I'm guessing this is not too hard to fix, but I might be wrong.

Anyone else should feel free to grab this bug.

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb0f17992844eca710c660cb4ce25d0686a184b3

commit cb0f17992844eca710c660cb4ce25d0686a184b3
Author: fs <fs@opera.com>
Date: Tue Nov 29 15:00:34 2016

Cleanup SVGMarkerData::updateFromPathElement

Make the updateFromPathElement "closure" a simple thunk-style function,
to make it a little less unwieldy. Also pass PathElement& rather than
PathElement*.

BUG=633012, 450368 

Review-Url: https://codereview.chromium.org/2540513005
Cr-Commit-Position: refs/heads/master@{#434987}

[modify] https://crrev.com/cb0f17992844eca710c660cb4ce25d0686a184b3/third_party/WebKit/Source/core/layout/svg/SVGMarkerData.h

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5372970166aa5d5124da806c698558d27e2dad5

commit f5372970166aa5d5124da806c698558d27e2dad5
Author: fs <fs@opera.com>
Date: Tue Nov 29 15:07:21 2016

Use the right point for marker orientation when closing a subpath

Path::apply doesn't pass a point along for the PathElementCloseSubpath
command. This would yield the wrong orientation on the last marker-mid
on the path (see crbug.com/633012#c1 for an example.)
Use m_subpathStart where needed instead.

BUG=633012

Review-Url: https://codereview.chromium.org/2539763002
Cr-Commit-Position: refs/heads/master@{#434988}

[add] https://crrev.com/f5372970166aa5d5124da806c698558d27e2dad5/third_party/WebKit/LayoutTests/svg/markers/marker-orientation-close-path-expected.html
[add] https://crrev.com/f5372970166aa5d5124da806c698558d27e2dad5/third_party/WebKit/LayoutTests/svg/markers/marker-orientation-close-path.html
[modify] https://crrev.com/f5372970166aa5d5124da806c698558d27e2dad5/third_party/WebKit/Source/core/layout/svg/SVGMarkerData.h

Comment 6 by f...@opera.com, Dec 16 2016

Blocking: 674797
Project Member

Comment 7 by sheriffbot@chromium.org, Mar 9 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Recharge-Cold -OS-All OS-Android OS-Chrome OS-Fuchsia OS-Linux OS-Mac OS-Windows
Owner: ----
Status: Fixed (was: Untriaged)
The given test case is fixed.
Status: Available (was: Fixed)
The TC from the description still renders incorrectly (both marker-start/end should point in the same direction - the one from c#1 is fixed though.)

Sign in to add a comment