New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632969 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Bug in extension "1-click-timer"

Reported by evo...@gmail.com, Jul 30 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.34 Safari/537.36

Example URL:
https://chrome.google.com/webstore/detail/1-click-timer/igloknlllonknnbkfgggfkigmeegmakf

Steps to reproduce the problem:
1. Install extension from https://chrome.google.com/webstore/detail/1-click-timer/igloknlllonknnbkfgggfkigmeegmakf
2. Click on the timer button on toolbar
3. Mouseover timer face and see glitches

What is the expected behavior?
Timer should look normally.

What went wrong?
Timer is not looking normally.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? Yes In v52.

Does this work in other browsers? Yes 

Chrome version: 53.0.2785.34  Channel: beta
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 22.0 r0

It was ok in Chrome beta v52. Noticed this after upgraded today to beta v53. Same in latest canary.
 
Cc: tkonch...@chromium.org jochen@chromium.org
Labels: -Pri-2 -Type-Compat M-53 ReleaseBlock-Stable OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: lazyboy@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on win8.1 chrome version 53.0.2785.34 and canary - observing glitches on hovering the timer

This is working fine in stable version 52.0.2743.82. Hence a regression

Manual Bisect Info:
Good build:53.0.2747.0
Bad Build:53.0.2748.0

Bisect Tool Info:
You are probably looking for a change made after 395490 (known good), but no later than 395501 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/6de57089abaea05decce400f1bae7889b34e839b..e79f1dd40fc3a6591b1a30aa911eaf1fbb339e49

Possible suspect : https://chromium.googlesource.com/chromium/src/+/ee4adef0b70f13cb80a886ef639fc910c0b5ce6f

Please reassign if this is not related to your change.


Owner: fmalita@chromium.org
This seems to be
https://chromium.googlesource.com/chromium/src/+/4c1400381d16b6dcd8921a8f19a2ae9af4aac4cf
Assigning to fmalita@
Status: Started (was: Assigned)
M53 Stable launch is coming soon.Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix asap so it gets chance to bake in beta before stable promotion. Thank you.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8148eedf1595dab9ec126e3e20403bad53021db9

commit 8148eedf1595dab9ec126e3e20403bad53021db9
Author: fmalita <fmalita@chromium.org>
Date: Thu Aug 04 18:59:45 2016

Fix SVGImage::imageForCurrentFrameForContainer() sizing

SVGImageForContainer implements the Image interface, and reports a size
equal to the container size.

But its imageForCurrentFrame() implementation delegates to
SVGImage::imageForCurrentFrameForContainer(), which currently returns an
SkImage with a size equal to the SVG intrinsic size.

This mismatch between the size reported by SVGImageForContainer and the
size of the SkImage returned by its imageForCurrentFrame() is causing
problems when tiling.

The CL updates SVGImage::imageForCurrentFrameForContainer() to return an
SkImage reflecting the container size instead of intrinsic size.

New pixel test: fast/backgrounds/background-svg-scaling.html

BUG= 632969 , 633637 
R=schenney@chromium.org, pdr@chromium.org, fs@opera.com

Review-Url: https://codereview.chromium.org/2203093003
Cr-Commit-Position: refs/heads/master@{#409853}

[modify] https://crrev.com/8148eedf1595dab9ec126e3e20403bad53021db9/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/8148eedf1595dab9ec126e3e20403bad53021db9/third_party/WebKit/LayoutTests/fast/backgrounds/background-svg-scaling.html
[modify] https://crrev.com/8148eedf1595dab9ec126e3e20403bad53021db9/third_party/WebKit/LayoutTests/svg/canvas/canvas-default-object-sizing-expected.html
[modify] https://crrev.com/8148eedf1595dab9ec126e3e20403bad53021db9/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp

Status: Fixed (was: Started)

Comment 7 by f...@opera.com, Sep 23 2016

Cc: fmalita@chromium.org
 Issue 649325  has been merged into this issue.

Comment 8 by f...@opera.com, Sep 27 2016

 Issue 650634  has been merged into this issue.

Sign in to add a comment