ec/util/getversion.sh needs cleaning |
||||||
Issue descriptionVERSION and CROS_EC_VERSION are set to exactly the same string, and VERSION does not seem to be used anywhere but in Makefile.rules, for not entirely clear reason. It sure should be enough to have a single variable.
,
Mar 31 2017
Is this fixed?
,
Apr 21 2017
no, this has not yet been fixed.
,
Oct 17 2017
,
May 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/2531d5787184d78187ccb8dc857aea0e766892d8 commit 2531d5787184d78187ccb8dc857aea0e766892d8 Author: Vadim Bendebury <vbendeb@chromium.org> Date: Wed May 23 04:57:12 2018 util: do not generate redundant CROS_EC_VERSION The values of CROS_EC_VERSION and VERSION variables generated by getversion.sh are exactly the same. VERSION is used in more places than CROS_EC_VERSION, let's keep VERSION and use it everywhere. BRANCH=none BUG= chromium:632937 TEST=make buildall Change-Id: Ibec9ecdd4b67789a468dddfbc1c82565f90d48a8 Signed-off-by: Vadim Bendebury <vbendeb@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1069330 Reviewed-by: Randall Spangler <rspangler@chromium.org> [modify] https://crrev.com/2531d5787184d78187ccb8dc857aea0e766892d8/common/version.c [modify] https://crrev.com/2531d5787184d78187ccb8dc857aea0e766892d8/util/getversion.sh
,
May 23 2018
,
Jul 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/e9a415c5d9fc09bc265b9bbd74961dd1fc2d3a2a commit e9a415c5d9fc09bc265b9bbd74961dd1fc2d3a2a Author: Vadim Bendebury <vbendeb@chromium.org> Date: Fri Jul 06 18:34:23 2018 util: do not generate redundant CROS_EC_VERSION The values of CROS_EC_VERSION and VERSION variables generated by getversion.sh are exactly the same. VERSION is used in more places than CROS_EC_VERSION, let's keep VERSION and use it everywhere. BRANCH=none BUG= chromium:632937 TEST=make buildall Change-Id: Ibec9ecdd4b67789a468dddfbc1c82565f90d48a8 Signed-off-by: Vadim Bendebury <vbendeb@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1069330 Reviewed-by: Randall Spangler <rspangler@chromium.org> (cherry picked from commit 2531d5787184d78187ccb8dc857aea0e766892d8) Reviewed-on: https://chromium-review.googlesource.com/1111622 Reviewed-by: Mary Ruthven <mruthven@chromium.org> Commit-Queue: Mary Ruthven <mruthven@chromium.org> Tested-by: Mary Ruthven <mruthven@chromium.org> [modify] https://crrev.com/e9a415c5d9fc09bc265b9bbd74961dd1fc2d3a2a/common/version.c [modify] https://crrev.com/e9a415c5d9fc09bc265b9bbd74961dd1fc2d3a2a/util/getversion.sh
,
Aug 3
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/716de0fb18934b58ca9b79e5839597f5a9d5cad4 commit 716de0fb18934b58ca9b79e5839597f5a9d5cad4 Author: Vadim Bendebury <vbendeb@chromium.org> Date: Fri Aug 03 19:50:35 2018 util: do not generate redundant CROS_EC_VERSION The values of CROS_EC_VERSION and VERSION variables generated by getversion.sh are exactly the same. VERSION is used in more places than CROS_EC_VERSION, let's keep VERSION and use it everywhere. BRANCH=none BUG= chromium:632937 TEST=make buildall Change-Id: Ibec9ecdd4b67789a468dddfbc1c82565f90d48a8 Signed-off-by: Vadim Bendebury <vbendeb@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1069330 Reviewed-by: Randall Spangler <rspangler@chromium.org> (cherry picked from commit 2531d5787184d78187ccb8dc857aea0e766892d8) Reviewed-on: https://chromium-review.googlesource.com/1111622 Reviewed-by: Mary Ruthven <mruthven@chromium.org> Commit-Queue: Mary Ruthven <mruthven@chromium.org> Tested-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1162592 [modify] https://crrev.com/716de0fb18934b58ca9b79e5839597f5a9d5cad4/common/version.c [modify] https://crrev.com/716de0fb18934b58ca9b79e5839597f5a9d5cad4/util/getversion.sh |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by lafo...@chromium.org
, Oct 4 2016