User menu not aligned to user button |
|||||||||||||
Issue description+ Windows 10, Chrome Canary v54.0.2811.0 By default, Windows machines can ship their devices with a display setting of 150%. That essentially means scaling our 1x UI to 150%. I'm not sure if that's the root cause of the mis-alignment on my Surface 2 but it's peculiar because the user menu is aligned properly when the display setting is dialed down to 100%. Ideally, they are aligned on both display settings but it's important that they align in the machine's recommended setting (150%). + Mac OSX, Chrome Canary v51.0.2704.106 The user menu is aligned on non-retina, but mis-aligned on retina by 1px. Ideally, the user menu is aligned on both display settings.
,
Jul 30 2016
Correction: Mac OSX, Chrome Canary v54.0.2811.2
,
Aug 1 2016
Based on the Mac screenshot the menu on Retina is 1pt (2px) too far to the left (i.e. it's not a 1/2pt problem). Moving the menu 1pt to the right should fix it. As for why you would have to move it 1pt to the right on Retina I'm not sure - you have to double-check the menu positioning code.
,
Aug 2 2016
Fixing Jane's LDAP :)
,
Aug 9 2016
,
Aug 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd2995fb57c078db3de42e5ad46faf5ad428e80d commit bd2995fb57c078db3de42e5ad46faf5ad428e80d Author: janeliulwq <janeliulwq@google.com> Date: Thu Aug 11 14:29:24 2016 [Mac][MD User Menu] UI Tweaks Specifically: 1. Fixed misalignment between user menu and avatar button (see bug #1) 2. Fixed pixelated profile icon border (see bug #2 ) 3. Fixed certain letters being cut off on the bottom for avatar name 4. Disabled the color change for button icons upon mouse down 5. Disabled focus for buttons that are disabled (see bug #3 ) See comparative screenshots: https://drive.google.com/corp/drive/folders/0B7Fvv7JszRyGWUtYM29OdnVjQm8 BUG= 632936 BUG= 633175 BUG= 633877 BUG= 615893 Review-Url: https://codereview.chromium.org/2197253002 Cr-Commit-Position: refs/heads/master@{#411323} [modify] https://crrev.com/bd2995fb57c078db3de42e5ad46faf5ad428e80d/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm [modify] https://crrev.com/bd2995fb57c078db3de42e5ad46faf5ad428e80d/chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm [modify] https://crrev.com/bd2995fb57c078db3de42e5ad46faf5ad428e80d/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
,
Aug 11 2016
The above CL aims to fix the misalignment on mac. I moved the menu to the right by 1pt, but let me know if that doesn't look right. Thanks!
,
Aug 23 2016
Marking as Fixed per above CL
,
Aug 23 2016
Re #8: This has not been fixed on Windows.
,
Aug 23 2016
My bad :( Re-opening
,
Aug 23 2016
,
Aug 26 2016
,
Sep 7 2016
,
Oct 5 2016
,
Oct 14 2016
I'll take this bug as I need to ramp up on Chrome Windows.
,
Nov 18 2016
As this was fixed on Mac, I'm dropping Mac from the list of OS-es.
,
Dec 19 2016
--Chrome Identity automated triaging-- This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 30 2017
Re-assigning to emx@
,
Mar 30 2017
Oh, huh, strange. Alan - does that look right to you? Is it correctly aligned now? |
|||||||||||||
►
Sign in to add a comment |
|||||||||||||
Comment 1 by bettes@chromium.org
, Jul 30 2016