Chrome .offsetHeight on <br> returns 0, doesn't match getBoundingClientRect().height
Reported by
bbri...@microsoft.com,
Jul 30 2016
|
||||
Issue descriptionOS: it's not XP What steps will reproduce the problem? (1) https://jsfiddle.net/rwty0pbn/ What is the expected output? Not a zero, same value as other APIs What do you see instead? Chrome: 0 for offsetHeight, 17 for gBCR.height Firefox: 19 for both Edge: 18 offsetHeight, 18.39 for gBCR.height Note: We found this while investigating CKEditor interop issue on lego.com site
,
Aug 2 2016
Can I take this?
,
Aug 2 2016
This is because LayoutBR inherits from LayoutText rather than LayoutBoxModelObject and thus doesn't have the offsetHeight method.
,
Aug 2 2016
Sure hyungwook.lee, it's all yours. HTMLElement::offsetHeightForBinding in HTMLElement.cpp is the method that gets called when invoking element.offsetHeight.
,
Mar 28 2017
So, we should make LayoutBR inherit from LayoutBoxModelObject or just try to fix it by computing the height differently in offsetHeightForBinding
,
Apr 12 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 18 2018
Fixed in LayoutNG. We won't get around to fix it in legacy layout. |
||||
►
Sign in to add a comment |
||||
Comment 1 by e...@chromium.org
, Aug 1 2016