New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632925 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Android Cronet Data Reduction Proxy Build fails cronet_test_instrumentation

Project Member Reported by ssid@chromium.org, Jul 30 2016

Issue description

Failed build:
https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20Cronet%20Data%20Reduction%20Proxy%20Builder/builds/2768

stack trace:
I   53.840s run_tests_on_device(06948af3003b97d1)    Error in testRequestFinishedListenerFailedRequest:
I   53.840s run_tests_on_device(06948af3003b97d1)    java.lang.Throwable: CronetTestBase#runTest failed.
I   53.840s run_tests_on_device(06948af3003b97d1)    	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:147)
I   53.840s run_tests_on_device(06948af3003b97d1)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
I   53.840s run_tests_on_device(06948af3003b97d1)    	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
I   53.840s run_tests_on_device(06948af3003b97d1)    	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
I   53.840s run_tests_on_device(06948af3003b97d1)    	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
I   53.840s run_tests_on_device(06948af3003b97d1)    Caused by: junit.framework.AssertionFailedError
I   53.840s run_tests_on_device(06948af3003b97d1)    	at org.chromium.net.RequestFinishedListenerTest.testRequestFinishedListenerFailedRequest(RequestFinishedListenerTest.java:235)
I   53.841s run_tests_on_device(06948af3003b97d1)    	at java.lang.reflect.Method.invokeNative(Native Method)
I   53.841s run_tests_on_device(06948af3003b97d1)    	at org.chromium.net.CronetTestBase.runTest(CronetTestBase.java:144)
I   53.841s run_tests_on_device(06948af3003b97d1)    	... 9 more


Suspected Cl:

Changed by	mgersh@chromium.org
Changed at	Fri 29 Jul 2016 14:17:54
Repository	https://chromium.googlesource.com/chromium/src
Project	src
Branch	master
Revision	c1c13d3a04dad56eef598824921cdb5d78be5997
Comments

Delete old NetworkQualityEstimator Cronet API

Now that RequestFinishedListener doesn't depend on NQE's executor, the
rest of this API can go away.

BUG=618034

Review-Url: https://codereview.chromium.org/2188553002
Cr-Commit-Position: refs/heads/master@{#408754}
Changed files

components/cronet/android/api/src/org/chromium/net/CronetEngine.java
components/cronet/android/api/src/org/chromium/net/JavaCronetEngine.java
components/cronet/android/cronet_url_request_context_adapter.cc
components/cronet/android/cronet_url_request_context_adapter.h
components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequestContext.java
 
Components: Internals>Network>Library
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/451b6e4a2fd610565ed0102894b9975472ed2414

commit 451b6e4a2fd610565ed0102894b9975472ed2414
Author: mgersh <mgersh@chromium.org>
Date: Mon Aug 01 16:28:12 2016

Fix flaky testRequestFinishedListenerFailedRequest

The time reported can occasionally be 0.

BUG= 632925 

Review-Url: https://codereview.chromium.org/2198083002
Cr-Commit-Position: refs/heads/master@{#408975}

[modify] https://crrev.com/451b6e4a2fd610565ed0102894b9975472ed2414/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedListenerTest.java

Status: Fixed (was: Untriaged)
I believe this should be fixed. Will reopen if the flake still happens.

Sign in to add a comment