New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632890 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 608476
issue 608486
issue 609988



Sign in to add a comment

cc_perftests don't bisect

Project Member Reported by dtu@chromium.org, Jul 29 2016

Issue description

Noted in issue 609988: cc_perftests times out because there's no output after 2 minutes. It's run with --verbose on chromium.perf but not on tryserver.chromium.perf, so it only happens with bisects. So the quickest thing is to add --verbose to the bisect command.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05639ea3eebccf27d97bc031755d52f7a9feaaac

commit 05639ea3eebccf27d97bc031755d52f7a9feaaac
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Wed Aug 03 01:54:44 2016

Roll src/third_party/catapult/ 3a63e0b7d..a95bbdfc8 (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/3a63e0b7da90..a95bbdfc8de9

$ git log 3a63e0b7d..a95bbdfc8 --date=short --no-merges --format='%ad %ae %s'

BUG= 632890 

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2207533003
Cr-Commit-Position: refs/heads/master@{#409428}

[modify] https://crrev.com/05639ea3eebccf27d97bc031755d52f7a9feaaac/DEPS

Blocking: 608486
Blocking: 608476

Comment 4 by dtu@chromium.org, Aug 5 2016

Status: Fixed (was: Started)

Comment 5 by dtu@chromium.org, Aug 5 2016

Cc: dtu@chromium.org
Owner: sullivan@chromium.org
Status: Assigned (was: Fixed)
-> sullivan to deploy perf dashboard
Owner: dtu@chromium.org
I deployed the perf dashboard, but it looks like https://codereview.chromium.org/2196753003/ did not have the desired effect:

https://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus7_perf_bisect/builds/3168

Test command is:
src/build/android/test_runner.py gtest --release -s cc_perftests

That CL would have the test command be:
./out/Release/cc_perftests --test-launcher-print-test-stdio=always --verbose

There seems to be some dead code here confusing where to put the '--verbose' option. Dave, can you take another look?
Just an update:

Observed similar failure on android_nexus9_perf_bisect 

Failed steps failed gathering reference values.performance test 1 of 5 failed gathering reference values.performance test 2 of 5 failed gathering reference values.performance test 3 of 5 failed gathering reference values.performance test 4 of 5 failed gathering reference values.performance test 5 of 5 failed gathering reference values.performance test 1 of 5 (2) failed gathering reference values.performance test 2 of 5 (2) failed gathering reference values.performance test 3 of 5 (2) failed gathering reference values.performance test 4 of 5 (2) failed gathering reference values.performance test 5 of 5 (2) failed gathering reference values.recipe failed. reason: testing the "good" revision failed

Build Path: 
===========
https://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus9_perf_bisect/builds/2003

Log Path: 
==========
https://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus9_perf_bisect/builds/2003/steps/steps/logs/stdio

Comment 8 by dtu@chromium.org, Aug 9 2016

Ah, it's because there's separate code paths on desktop and Android. Will upload a fix...
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef570a8b687041e2ef908e0cd57d9f183a08e702

commit ef570a8b687041e2ef908e0cd57d9f183a08e702
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Wed Aug 10 02:21:32 2016

Roll src/third_party/catapult/ 280817e10..dc610de4c (2 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/280817e10a2c..dc610de4cce6

$ git log 280817e10..dc610de4c --date=short --no-merges --format='%ad %ae %s'

BUG= 632890 

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2233583002
Cr-Commit-Position: refs/heads/master@{#410926}

[modify] https://crrev.com/ef570a8b687041e2ef908e0cd57d9f183a08e702/DEPS

Cc: aiolos@chromium.org
There is a related bug 636471 but I think that is a separate issue.

Comment 12 by dtu@chromium.org, Aug 15 2016

Comment 10: Looks like an Android-specific separate issue. Could you file another bug?

Comment 13 by dtu@chromium.org, Feb 8 2017

Status: Fixed (was: Assigned)

Sign in to add a comment