Disable touch events but not pointer events for touch |
||||||||
Issue descriptionFor testing purposes and because some users might prefer this on desktop to work around sites that are broken with touch+mouse, we should have some flag that disables the touch events API but leaves pointer events working properly for touch. I.e. makes us behave like Edge desktop in this regard. I thought simply disabling chrome://flags/#touch-events would do that, but it looks like that's broken - still fires touch events. Maybe it just turns off the feature detection APIs while still letting the events through? Obviously we'd still want the WebTouchEvents to go to blink. Perhaps we're just missing a RuntimeEnabledFeatures::touchEnabled check in PointerEventManager where it calls into TouchEventManager? Or it looks like it might be easier at the moment to put those checks into TouchEventManager itself?
,
Aug 2 2016
Just preventing TE dispatch should be enough but need to consider possible side-effects of "disabled cc touch hit testing machinery". Trying to figure out, any comments?
,
Aug 2 2016
Looks like touch-action could be affected.
,
Aug 3 2016
Yeah we want the 'Touch' RuntimeEnabledFeature disabled so that touch event feature detection (like "ontouchstart" in window) doesn't pass. But we need to make sure that CC touch hit-testing is still functioning for the sake of touch-action. Perhaps CC touch hit testing should just always be active now - you never know when a touch screen could be plugged in via USB and we probably should handle that case for pointer events (which don't have the same constraints the TouchEvent API does). dtapuska@ any thoughts?
,
Aug 3 2016
If you can't construct a TouchEvent in JS; we shouldn't dispatch the events. And I do think we should always update the touch rects. Since this code would typically run on mobile which is lower powered there should technically be no reason not to enable it always on desktop.
,
Sep 28 2016
Issue 645121 has been merged into this issue.
,
Sep 28 2016
,
Oct 13 2016
,
Feb 22 2017
@rbyers: With chrome://flags/#touch-events controlling only TouchEvent-feature-detection from M57, I think we are done here. In other words, we don't need a separate flag to suppress firing TouchEvent altogether, right?
,
Dec 7
,
Jan 18
(5 days ago)
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rbyers@chromium.org
, Jul 29 2016