New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632875 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 635947



Sign in to add a comment

DevTools: add ability to wait for async code while evaluation to protocol

Project Member Reported by kozyatinskiy@chromium.org, Jul 29 2016

Issue description

Roadmap:
- introduce awaitPromise method;
- introduce isAsync flag;
- migrate clients.
 
Components: Platform>DevTools Platform>DevTools>JavaScript
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d917a5dc76f1de93239f06864352cea9d278603

commit 6d917a5dc76f1de93239f06864352cea9d278603
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Sat Jul 30 02:48:35 2016

[DevTools] Added Runtime.awaitPromise protocol method

Method will call callback when promise is fulfilled, rejected or collected.

BUG= 632875 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2185233002
Cr-Commit-Position: refs/heads/master@{#408849}

[modify] https://crrev.com/6d917a5dc76f1de93239f06864352cea9d278603/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html
[add] https://crrev.com/6d917a5dc76f1de93239f06864352cea9d278603/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-await-promise-expected.txt
[add] https://crrev.com/6d917a5dc76f1de93239f06864352cea9d278603/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-await-promise.html
[modify] https://crrev.com/6d917a5dc76f1de93239f06864352cea9d278603/third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp
[modify] https://crrev.com/6d917a5dc76f1de93239f06864352cea9d278603/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/6d917a5dc76f1de93239f06864352cea9d278603/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
[modify] https://crrev.com/6d917a5dc76f1de93239f06864352cea9d278603/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 2 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ce09555b528b623d9103e77226472af0a7dabeb

commit 0ce09555b528b623d9103e77226472af0a7dabeb
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Wed Aug 03 00:57:25 2016

[DevTools] Add awaitPromise flag to Runtime.runScript

- added awaitPromise flag,
- added returnByValue and generatePreview flags to align with other evaluate methods,
- marked executionContextId as optional.

BUG= 632875 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2203073004
Cr-Commit-Position: refs/heads/master@{#409408}

[modify] https://crrev.com/0ce09555b528b623d9103e77226472af0a7dabeb/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-callFunctionOn-async-expected.txt
[modify] https://crrev.com/0ce09555b528b623d9103e77226472af0a7dabeb/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-callFunctionOn-async.html
[modify] https://crrev.com/0ce09555b528b623d9103e77226472af0a7dabeb/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-async-expected.txt
[add] https://crrev.com/0ce09555b528b623d9103e77226472af0a7dabeb/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-runScript-async-expected.txt
[add] https://crrev.com/0ce09555b528b623d9103e77226472af0a7dabeb/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-runScript-async.html
[modify] https://crrev.com/0ce09555b528b623d9103e77226472af0a7dabeb/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html
[modify] https://crrev.com/0ce09555b528b623d9103e77226472af0a7dabeb/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
[modify] https://crrev.com/0ce09555b528b623d9103e77226472af0a7dabeb/third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js
[modify] https://crrev.com/0ce09555b528b623d9103e77226472af0a7dabeb/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
[modify] https://crrev.com/0ce09555b528b623d9103e77226472af0a7dabeb/third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.h
[modify] https://crrev.com/0ce09555b528b623d9103e77226472af0a7dabeb/third_party/WebKit/Source/platform/v8_inspector/js_protocol.json

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad603bf9b913f02ab9e81abffb2b630776f18c19

commit ad603bf9b913f02ab9e81abffb2b630776f18c19
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Wed Aug 03 20:12:16 2016

[DevTools] InspectorTest.evaluateInPageAsync uses Runtime.evaluate

InspectorTest.evaluateInPageAsync uses Runtime.evaluate with awaitPromise flag.

BUG= 632875 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2207093002
Cr-Commit-Position: refs/heads/master@{#409605}

[modify] https://crrev.com/ad603bf9b913f02ab9e81abffb2b630776f18c19/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html
[modify] https://crrev.com/ad603bf9b913f02ab9e81abffb2b630776f18c19/third_party/WebKit/LayoutTests/inspector-protocol/worker/worker-console.html

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55da79583bf83778309007c14f53092295cc0a7d

commit 55da79583bf83778309007c14f53092295cc0a7d
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Aug 05 18:21:59 2016

[DevTools] Removed InspectorTest.invokePageFunctionPromise

BUG= 632875 
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2207163002
Cr-Commit-Position: refs/heads/master@{#410114}

[modify] https://crrev.com/55da79583bf83778309007c14f53092295cc0a7d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/55da79583bf83778309007c14f53092295cc0a7d/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-deletion.html
[modify] https://crrev.com/55da79583bf83778309007c14f53092295cc0a7d/third_party/WebKit/LayoutTests/http/tests/inspector/cache-storage/cache-storage-test.js
[modify] https://crrev.com/55da79583bf83778309007c14f53092295cc0a7d/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/55da79583bf83778309007c14f53092295cc0a7d/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-force-update-on-page-load.html
[modify] https://crrev.com/55da79583bf83778309007c14f53092295cc0a7d/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-workers-test.js
[modify] https://crrev.com/55da79583bf83778309007c14f53092295cc0a7d/third_party/WebKit/LayoutTests/inspector/elements/hide-shortcut.html

Blocking: 635947
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a029bcf5871341046967c6e8f6d640eacb8c6134

commit a029bcf5871341046967c6e8f6d640eacb8c6134
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Fri Aug 12 23:24:28 2016

[DevTools] Removed InspectorTest.invokeFunctionInPageAsync

BUG= 632875 
R=caseq@chromium.org

Review-Url: https://codereview.chromium.org/2208963002
Cr-Commit-Position: refs/heads/master@{#411813}

[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/tracing-test.js
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/http/tests/inspector/console-fetch-logging-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/http/tests/inspector/console-fetch-logging.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-eventsource.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/http/tests/inspector/resources/extension-main.js
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-script-parse.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-xhr-event.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/http/tests/inspector/tracing/timeline-xhr-response-type-blob-event.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/http/tests/inspector/tracing/websocket/timeline-websocket-event.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-dispatchEvent.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-layout.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-raf.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector-protocol/timeline/timeline-timer.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/elements/css-rule-hover-highlights-selectors.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/extensions/extensions-resources.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing-session-id.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/anonymous-image-object.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/decode-resize.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/frame-model-instrumentation.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/scroll-invalidations.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-gc-event.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-script-id-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-js/timeline-script-id.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout/timeline-layout-with-invalidations-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-layout/timeline-layout-with-invalidations.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-animation-frame-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-animation-frame.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-event-causes.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-grouped-invalidations-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-grouped-invalidations.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-load-event.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-misc/timeline-receive-response-event.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-received-data.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource-details.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-network/timeline-network-resource.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/layer-tree.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/paint-profiler-update.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-layout-invalidations.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/timeline-paint.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-paint/update-layer-tree.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/parse-author-style-sheet.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-all-invalidator-types-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-all-invalidator-types.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidations-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidations.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-style/timeline-style-recalc-with-invalidator-invalidations.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-timer-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-timer-fired-from-eval-call-site.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/timeline-time/timeline-timer.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/worker-events.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/inspector/tracing/worker-js-frames.html
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/virtual/threaded/inspector/tracing/idle-callback-expected.txt
[modify] https://crrev.com/a029bcf5871341046967c6e8f6d640eacb8c6134/third_party/WebKit/LayoutTests/virtual/threaded/inspector/tracing/idle-callback.html

Status: Fixed (was: Assigned)

Sign in to add a comment