New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632827 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

move ui/chromeos/network/ to ash/common/system/network/

Project Member Reported by est...@chromium.org, Jul 29 2016

Issue description

see discussion at https://codereview.chromium.org/2186353002/

jamescook@, any objections?
 
Talked to stevenjb@ just now. I support moving this code back to //ash.

The network code in //ui/chromeos was moved there for athena, which needed networking UI but couldn't depend on //chrome or //ash. Athena doesn't exist anymore, so we don't need a separate //ui/chromeos.

See https://codereview.chromium.org/351353004 for a bit of history.

Long term we want chromeos chrome to be like linux chrome, and not have ash dependencies. That day is a long time away, however. Even if we break the code dependency, we could still share the art assets if we needed them for webui in chrome.

Consider moving the code into //ash/common/system/chromeos/network, unless the code is non-chromeos-specific.  (Our project builds ash on windows for test/debugging.)

Comment 2 by est...@chromium.org, Oct 26 2016

Owner: steve...@chromium.org
Status: Fixed (was: Assigned)

Comment 3 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 4 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 5 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment