New issue
Advanced search Search tips

Issue 632781 link

Starred by 3 users
Status: Fixed
Owner:
mmenke@chromium.org
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

No error page on empty 404 pages

Project Member Reported by mmenke@chromium.org, Jul 29 2016 
We don't display our own error page when a server gives us a 404 response with an empty page.  We do with a number of other common HTTP errors (403, 410, 500-504).  We should add one for 404s.

The reason the 404 error page is missing is that we used to just use a Link Doctor page in this case, but we now mix Link Doctor errors with our own error pages, so we need our own error page for 404s to display Link Doctor information.

This broke a while back, but all error pages for 4xx/5xx responses broke before that, and was only recently fixed, so while it's a regression, it's not a recent one, and has been masked by another regression for ~5 years.

Comment 1 by mmenke@chromium.org, Aug 3 2016

Status: Fixed (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c

commit d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c
Author: mmenke <mmenke@chromium.org>
Date: Wed Aug 03 17:58:49 2016

Add an error page for HTTP 404 error pages without bodies.

We used to show Link Doctor pages in this case, but that broke long ago.
 https://crbug.com/331745  was recently fixed, which allows us to show error
pages in that case once more.

Also add a browser test for HTTP 500 errors pages without bodies, which
also fixed by that CL.

Also fixes a bunch of browser tests that implicitly depend on *not* showing
error pages when we get a 404 response without a body.

BUG= 632781 , 331745 

Review-Url: https://codereview.chromium.org/2190463008
Cr-Commit-Position: refs/heads/master@{#409567}

[modify] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/chrome/android/javatests/src/org/chromium/chrome/browser/RepostFormWarningTest.java
[modify] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java
[modify] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/chrome/browser/errorpage_browsertest.cc
[modify] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/chrome/browser/extensions/activity_log/activity_log_browsertest.cc
[modify] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc
[modify] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/chrome/browser/ssl/chrome_security_state_model_client_browser_tests.cc
[modify] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/chrome/browser/ssl/ssl_browser_tests.cc
[modify] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/chrome/browser/ui/browser_browsertest.cc
[add] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/chrome/test/data/errorpage/empty404.html
[add] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/chrome/test/data/errorpage/empty404.html.mock-http-headers
[add] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/chrome/test/data/errorpage/empty500.html
[add] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/chrome/test/data/errorpage/empty500.html.mock-http-headers
[modify] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/chrome/test/data/extensions/api_test/runtime/content_script/manifest.json
[modify] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/chrome/test/data/extensions/api_test/webnavigation/serverRedirect/test_serverRedirect.js
[modify] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/chrome/test/data/extensions/api_test/webnavigation/serverRedirectSingleProcess/test_serverRedirectSingleProcess.js
[modify] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/chrome/test/data/form.html
[modify] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/components/error_page/common/localized_error.cc
[modify] https://crrev.com/d485e9156b72ea4bb4682ffbf73ea0eb248ecb6c/extensions/browser/api/runtime/runtime_apitest.cc
►

Sign in to add a comment