Add generic error page for blank HTTP 4xx/5xx errors. |
||||
Issue descriptionWith issue 331745 fixed, we can now show error pages when a server sends us blank HTTP error pages once more. We have specific error pages for 403, 410, and 500-504 HTTP errors (I'm adding a 404 one now - we used to rely on link doctor forthat, but now since we mix link doctor with normal error pages, we need one). We should consider adding a generic page for other 4xx/5xx errors. They're less common, but seems like we should at least be showing something. [edwardjung]: Thoughts?
,
Aug 11 2016
Yes, I agree. Is there anything needed from us?
,
Aug 11 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 14 2017
Any plans to move forward on this?
,
Aug 14 2017
Not to the extent of my knowledge.
,
Aug 16 2017
Er - UXer question. What do we need to move forward here?
,
Aug 16 2017
We either need to add error strings to "LocalizedErrorMap http_error_options" or add a fallback case to LookupErrorMap() for HTTP status codes. It's purely UI work. All the code to hook it up is already in place.
,
Aug 16 2017
That's good to know! Edward - can you help me with figuring out what's needed here exactly? I'm sure we can offer string suggestions fairly easily. :)
,
Aug 16 2017
(Punting out of network bug triager's queue)
,
Aug 24 2017
Rachel, we just need to decide on the strings for heading and summary paragraph we want to show for these types of errors. 4xx errors - Errors caused by the client. 5xx errors - Server errors where the server failed to fulfill an apparently valid request You can see the type of errors in each category here: https://en.wikipedia.org/wiki/List_of_HTTP_status_codes We can sync off bug to figure out some wording.
,
Sep 29 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e9976bf5b914bfd84d71d3d59c2d3db4b754a23 commit 0e9976bf5b914bfd84d71d3d59c2d3db4b754a23 Author: Edward Jung <edwardjung@chromium.org> Date: Fri Sep 29 09:44:03 2017 Show generic network error interstitial for 4xx / 5xx errors that do not have any content Currently only a small subset of 4xx and 5xx HTTP errors show a net error interstitial when the server responds with no content. This CL adds generic messaging for the other cases. Bug: 632778 Change-Id: If39bf0ba1c89ac5e2b5a27f5973e1accc25dc0fa Reviewed-on: https://chromium-review.googlesource.com/685674 Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#505337} [modify] https://crrev.com/0e9976bf5b914bfd84d71d3d59c2d3db4b754a23/components/error_page/common/localized_error.cc [modify] https://crrev.com/0e9976bf5b914bfd84d71d3d59c2d3db4b754a23/components/error_page_strings.grdp
,
Sep 29 2017
Generic message added for 4xx/5xx errors. |
||||
►
Sign in to add a comment |
||||
Comment 1 by edwardjung@chromium.org
, Aug 1 2016