MediaSessionVisibility browser tests are very hard to modify |
||
Issue descriptionI'm trying to add new test cases for when resuming backgrounded videos is allowed and it seems very hard to read and modify the tests. There's a separate class (test fixture) for every test case with lots of similar protected methods in the base class. Seems like the test fixtures are different to setup the command line differently for each combination of unified pipeline & disable media suspend. Could we just setup the necessary parameters at the beginning of the test case? TestSessionXWhenY should also be one method with parameters (could we make MediaSession::State public for tests?).
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc32190deee8678fbc1b1be901cca5e9da9f0297 commit cc32190deee8678fbc1b1be901cca5e9da9f0297 Author: zqzhang <zqzhang@chromium.org> Date: Wed Sep 07 15:07:52 2016 Refactoring MediaSessionVisibility browser tests Using parameterized GTests to run MediaSessionVisibility browser tests to help make further modification easier. BUG= 632767 Review-Url: https://codereview.chromium.org/2299203005 Cr-Commit-Position: refs/heads/master@{#416939} [modify] https://crrev.com/cc32190deee8678fbc1b1be901cca5e9da9f0297/content/browser/media/session/media_session_visibility_browsertest.cc
,
Nov 2 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by avayvod@chromium.org
, Aug 1 2016