New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632737 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Turn off Autocomplete for fields with unrecognized attributes

Project Member Reported by se...@chromium.org, Jul 29 2016

Issue description

Currently*:

- Autofill is turned off for fields with an unrecognized autocomplete attribute.

- Autocomplete is turned off for fields with an "off" autocomplete attribute.

This leads to some inconsistent behavior where you can turn off one but not both Autofill and Autocomplete.

Autocomplete should also be turned off for field with an unrecognized autocomplete attribute.



* Except on desktop where Autofill is turned off for fields with the "off" autocomplete attribute.

 

Comment 1 by asredzki@google.com, Jul 29 2016

Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a652213cc933de7eed9adc9199117281a2965f08

commit a652213cc933de7eed9adc9199117281a2965f08
Author: asredzki <asredzki@google.com>
Date: Thu Aug 04 23:39:08 2016

Disable autocomplete with unknown autocomplete attribute value.

This is for consistent behaviour between autofill and autocomplete.

Improved autofill_manager_unittest readability with a convenience method
for using a MockAutofillHistoryManager and test naming consistency.

BUG= 632737 
R=mathp,sebsg
TEST=AutofillManagerTest*

Review-Url: https://codereview.chromium.org/2211193002
Cr-Commit-Position: refs/heads/master@{#409935}

[modify] https://crrev.com/a652213cc933de7eed9adc9199117281a2965f08/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/a652213cc933de7eed9adc9199117281a2965f08/components/autofill/core/browser/autofill_manager.h
[modify] https://crrev.com/a652213cc933de7eed9adc9199117281a2965f08/components/autofill/core/browser/autofill_manager_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment