New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 632730 link

Starred by 2 users
Status: Fixed
Owner:
█ bshe@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Add jar_excluded_patterns support for android_aar_prebuilt

Project Member Reported by bshe@chromium.org, Jul 29 2016 
gvr library has its own version of protobuf backed in its library. However, chromium also include a version of protobuf. This cause conflicts when we try to include gvr to chromium.
jar_excluded_patterns can be used to exclude protobuf in gvr. So add it to android_aar_prebuilt.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/396c2c1f6b3ff0183dcd27b8044442c9f5ba05e4

commit 396c2c1f6b3ff0183dcd27b8044442c9f5ba05e4
Author: bshe <bshe@chromium.org>
Date: Fri Jul 29 17:09:29 2016

Add jar_excluded_patterns support in android_aar_prebuilt

Gvr library needs to exclude protobuf classes(chromium has its own version)
in order to link properly with chromium. This CL adds
"jar_excluded_patterns" support for android_aar_prebuilt

BUG= 632730 

Review-Url: https://codereview.chromium.org/2188243002
Cr-Commit-Position: refs/heads/master@{#408667}

[modify] https://crrev.com/396c2c1f6b3ff0183dcd27b8044442c9f5ba05e4/build/config/android/rules.gni

Comment 2 by bshe@chromium.org, Aug 17 2016

Status: Fixed (was: Started)

Comment 3 by joshcarpenter@chromium.org, Sep 6 2016

Summary: VR: Add jar_excluded_patterns support for android_aar_prebuilt (was: Add jar_excluded_patterns support for android_aar_prebuilt)

Comment 4 by ddorwin@chromium.org, Dec 5 2016

Components: UI>Browser>VR
►

Sign in to add a comment