Tien has worked with Sebastien to finalize/polish the UI for Quick View Pane: - Updates to the color specs based on gallery app (https://folio.googleplex.com/crosfilesapppreviewpane/High%20fidelity%20visuals/Quick%20View/Mocks%20&%20Specs/07_25_2016#%2FSPEC%20-%20Color%20scheme.png%3Fz=fit) - Reducing the size (and color) of the placeholder icons (Assets folder: https://drive.google.com/corp/drive/folders/0B0p7OJNHkJw8dkxZRWViS3BDd2c) Final Sketch File: https://drive.google.com/corp/drive/folders/0B0p7OJNHkJw8SGszSzQ2dXdIaUk
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cc7cad39f158404fdd538add739a68c1c49397b5 commit cc7cad39f158404fdd538add739a68c1c49397b5 Author: oka <oka@chromium.org> Date: Thu Aug 04 08:16:45 2016 Quick View: Update UI to meet the latest mock. Mock is https://folio.googleplex.com/crosfilesapppreviewpane/High%20fidelity%20visuals/Quick%20View/Mocks%20&%20Specs/07_25_2016#%2FSPEC%20-%20Color%20scheme.png%3Fz=fit&c=show We also need to update placeholder icons to https://drive.google.com/corp/drive/u/0/folders/0B0p7OJNHkJw8dkxZRWViS3BDd2c, but I will do it in a separate CL. BUG= 632726 TEST=manually Review-Url: https://codereview.chromium.org/2205693006 Cr-Commit-Position: refs/heads/master@{#409737} [modify] https://crrev.com/cc7cad39f158404fdd538add739a68c1c49397b5/ui/file_manager/file_manager/foreground/elements/files_icon_button.html [modify] https://crrev.com/cc7cad39f158404fdd538add739a68c1c49397b5/ui/file_manager/file_manager/foreground/elements/files_metadata_box.html [modify] https://crrev.com/cc7cad39f158404fdd538add739a68c1c49397b5/ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html [modify] https://crrev.com/cc7cad39f158404fdd538add739a68c1c49397b5/ui/file_manager/file_manager/foreground/elements/files_quick_view.css [modify] https://crrev.com/cc7cad39f158404fdd538add739a68c1c49397b5/ui/file_manager/file_manager/foreground/elements/files_quick_view.html [modify] https://crrev.com/cc7cad39f158404fdd538add739a68c1c49397b5/ui/file_manager/file_manager/foreground/elements/files_ripple.js [modify] https://crrev.com/cc7cad39f158404fdd538add739a68c1c49397b5/ui/file_manager/file_manager/foreground/elements/icons.html [add] https://crrev.com/cc7cad39f158404fdd538add739a68c1c49397b5/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/2x/info_outline.png [add] https://crrev.com/cc7cad39f158404fdd538add739a68c1c49397b5/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/info_outline.png
Hi Tien. Sorry I didn't notice earlier, but please make assets' background transparent. Without transparency it looks wierd on Quick View (see the attached screenshot.)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb8ff59eb557fb0c22a55d6f05ddc2c120742536 commit bb8ff59eb557fb0c22a55d6f05ddc2c120742536 Author: oka <oka@chromium.org> Date: Wed Aug 17 02:52:13 2016 Quick View: Add a padding between key and value in metadata box. BUG= 632726 TEST=manually. Tested using Arabic too. Review-Url: https://codereview.chromium.org/2248263002 Cr-Commit-Position: refs/heads/master@{#412433} [modify] https://crrev.com/bb8ff59eb557fb0c22a55d6f05ddc2c120742536/ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3659ee3e38860a16f9a0a0b74581d0f0c3a74ff commit a3659ee3e38860a16f9a0a0b74581d0f0c3a74ff Author: oka <oka@chromium.org> Date: Wed Aug 17 03:38:59 2016 Quick View: Fix font size. Current font size was too large. Fixed it accordingly to the discussion [1] with the designer. Demo (internal only): https://drive.google.com/a/google.com/file/d/0B7EYjkGAjRAhRW9SRVBfSndjSms/view?usp=sharing [1] https://folio.googleplex.com/crosfilesapppreviewpane/High%20fidelity%20visuals/Quick%20View/Mocks%20&%20Specs/07_25_2016#%2FSPEC%20-%20Color%20scheme.png%3Fz=fit&c=show BUG= 632726 TEST=manually confirmed the font sizes are 12.96px and 14px (13.9968px actually). Also confirmed font size changes when OS's default font size is changed from medium. Review-Url: https://codereview.chromium.org/2243223002 Cr-Commit-Position: refs/heads/master@{#412441} [modify] https://crrev.com/a3659ee3e38860a16f9a0a0b74581d0f0c3a74ff/ui/file_manager/file_manager/foreground/elements/files_metadata_box.html [modify] https://crrev.com/a3659ee3e38860a16f9a0a0b74581d0f0c3a74ff/ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html [modify] https://crrev.com/a3659ee3e38860a16f9a0a0b74581d0f0c3a74ff/ui/file_manager/file_manager/foreground/elements/files_quick_view.css
Hi Oka-san - here are the assests with transparent backgrounds. Please let me know if you need anything else! https://drive.google.com/drive/folders/0B0p7OJNHkJw8R0xQc2NEYjhRYlE?usp=sharing https://drive.google.com/drive/folders/0B0p7OJNHkJw8VzFWWlJzZWtWMlU?usp=sharing
Thank you Tien! I've made a CL to use the new icons.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52acb747d0c1233db45fc6a5c4828a979e4e55ea commit 52acb747d0c1233db45fc6a5c4828a979e4e55ea Author: oka <oka@chromium.org> Date: Fri Aug 19 04:32:56 2016 Updated no-preview icons to the latest version (v3). BUG= 632726 TEST=manually. Review-Url: https://codereview.chromium.org/2259783004 Cr-Commit-Position: refs/heads/master@{#413050} [modify] https://crrev.com/52acb747d0c1233db45fc6a5c4828a979e4e55ea/ui/file_manager/file_manager/foreground/elements/files_quick_view.css [modify] https://crrev.com/52acb747d0c1233db45fc6a5c4828a979e4e55ea/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/2x/filetype_audio.png [modify] https://crrev.com/52acb747d0c1233db45fc6a5c4828a979e4e55ea/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/2x/filetype_folder.png [modify] https://crrev.com/52acb747d0c1233db45fc6a5c4828a979e4e55ea/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/2x/filetype_generic.png [modify] https://crrev.com/52acb747d0c1233db45fc6a5c4828a979e4e55ea/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/2x/filetype_image.png [modify] https://crrev.com/52acb747d0c1233db45fc6a5c4828a979e4e55ea/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/2x/filetype_video.png [modify] https://crrev.com/52acb747d0c1233db45fc6a5c4828a979e4e55ea/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/filetype_audio.png [modify] https://crrev.com/52acb747d0c1233db45fc6a5c4828a979e4e55ea/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/filetype_folder.png [modify] https://crrev.com/52acb747d0c1233db45fc6a5c4828a979e4e55ea/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/filetype_generic.png [modify] https://crrev.com/52acb747d0c1233db45fc6a5c4828a979e4e55ea/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/filetype_image.png [modify] https://crrev.com/52acb747d0c1233db45fc6a5c4828a979e4e55ea/ui/file_manager/file_manager/foreground/images/files/ui/quick_view/filetype_video.png
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/305f0e100a1a3563586c4ff01b47bdf3814ebe72 commit 305f0e100a1a3563586c4ff01b47bdf3814ebe72 Author: oka <oka@chromium.org> Date: Fri Aug 19 07:26:08 2016 Quick View: fixed the bug that 'No preview available' text is not shown. Fixed the bug that 'No preview available' text is not shown when the element for that does not exist when Files App is launched. BUG= 632726 TEST=manually confirmed translated text of 'No preview(playback) is available' is shown when audio, video or a folder in Drive is opened with Quick View using Japanese. Review-Url: https://codereview.chromium.org/2259433004 Cr-Commit-Position: refs/heads/master@{#413076} [modify] https://crrev.com/305f0e100a1a3563586c4ff01b47bdf3814ebe72/ui/file_manager/file_manager/foreground/elements/files_quick_view.html [modify] https://crrev.com/305f0e100a1a3563586c4ff01b47bdf3814ebe72/ui/file_manager/file_manager/foreground/elements/files_quick_view.js [modify] https://crrev.com/305f0e100a1a3563586c4ff01b47bdf3814ebe72/ui/file_manager/file_manager/main.html
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2561dc0f3f72edaea86101c2f87fd1352e2b6e52 commit 2561dc0f3f72edaea86101c2f87fd1352e2b6e52 Author: oka <oka@chromium.org> Date: Fri Aug 19 08:32:20 2016 Quick View: Stopped to show orange border when no-preview icon is clicked. Also make Quick View be closed when no-preview icon is clicked. BUG= 632726 TEST=Manually checked Quick View is closed when no preview (or playback) icon is clicked. Also tested Quick View is not closed when image/video/audio is clicked. Review-Url: https://codereview.chromium.org/2265433002 Cr-Commit-Position: refs/heads/master@{#413085} [modify] https://crrev.com/2561dc0f3f72edaea86101c2f87fd1352e2b6e52/ui/file_manager/file_manager/foreground/elements/files_quick_view.css [modify] https://crrev.com/2561dc0f3f72edaea86101c2f87fd1352e2b6e52/ui/file_manager/file_manager/foreground/elements/files_quick_view.html [modify] https://crrev.com/2561dc0f3f72edaea86101c2f87fd1352e2b6e52/ui/file_manager/file_manager/foreground/elements/files_quick_view.js
Comment 1 by bugdroid1@chromium.org
, Aug 4 2016