New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 632723 link

Starred by 4 users
Status: Duplicate
Merged: issue webrtc:7063
Owner:
hbos@chromium.org
Closed: Jan 2017
Cc:
hta@chromium.org
█ deadbeef@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue webrtc:6756
Blocking:
issue 627816



Sign in to add a comment

RTCPeerConnection.getStats: RTCIceCandidateStats is missing

Project Member Reported by hbos@chromium.org, Jul 29 2016 
RTCIceCandidateStats (http://rawgit.com/w3c/webrtc-stats/master/webrtc-stats.html#icecandidate-dict*) is missing.

As part of updating getStats ( bug 627816 ) these stats needs to be made available in WebRTC and surfaced to Blink.

Comment 1 by hbos@chromium.org, Oct 7 2016

Cc: hta@chromium.org deadbeef@chromium.org
The CL[1] in progress does not address an important TODO that needs to be addressed before closing this issue. Quoting deadbeef@:

  It's not sufficient to make candidate stats from ConnectionInfos (which are
  effectively candidate pairs). The channel could have candidates that aren't
  paired with anything.

  Really we need to add individual candidate lists to TransportChannelStats, and
  implement forming the list in P2PTransportChannel. Which isn't completely
  trivial, since there aren't ready-built lists; local candidates come from Port
  objects, and prflx candidates (both local and remote) are only stored in
  candidate pairs.

[1] https://codereview.webrtc.org/2384143002/

Comment 3 by hta@chromium.org, Oct 11 2016 

I think one example of such non-paired stats is if one end has IPv6 (and thus IPv6 candidates) and the other end has IPv4 only. The IPv6 candidates won't be paired with anything. But we still want them returned.
(This argues that candidates should be marked with whether they are remote or local, even when not paired. https://github.com/w3c/webrtc-stats/issues/65

This example may be useful in writing a test.

Comment 4 by hbos@chromium.org, Oct 11 2016

Components: Blink>WebRTC

Comment 5 by hbos@webrtc.org, Nov 23 2016

Blockedon: webrtc:6756

Comment 6 by anatolid@chromium.org, Nov 29 2016

Labels: M-57

Comment 7 by hbos@chromium.org, Dec 21 2016 

Draft 14 December 2016
https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-isremote

dictionary RTCIceCandidateStats : RTCStats {
    DOMString           transportId;
    boolean             isRemote;
    DOMString           ip;
    long                port;
    DOMString           protocol;
    RTCIceCandidateType candidateType;
    long                priority;
    DOMString           url;
    boolean             deleted = false;
};
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3a849d6f9efef1f90688ef3d11f8ca75618ac3a

commit a3a849d6f9efef1f90688ef3d11f8ca75618ac3a
Author: hbos <hbos@chromium.org>
Date: Mon Jan 02 16:43:12 2017

RTCPeerConnection.getStats: Whitelist updated after spec changed.

This is the whitelist used in the Chromium integration test.

New members:
- RTCRTPStreamStats.qpSum: https://w3c.github.io/webrtc-stats/#dom-rtcrtpstreamstats-qpsum
- RTCInboundRTPStreamStats.framesDecoded: https://w3c.github.io/webrtc-stats/#dom-rtcinboundrtpstreamstats-framesdecoded
- RTCOutboundRTPStreamStats.framesEncoded: https://w3c.github.io/webrtc-stats/#dom-rtcoutboundrtpstreamstats-framesencoded
- RTCIceCandidateStats.transportId: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-transportid
- RTCIceCandidateStats.isRemote: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-isremote
- RTCIceCandidateStats.deleted: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatestats-deleted

Renamed members, removed old names (https://codereview.webrtc.org/2576383002/):
- RTCIceCandidatePairStats.totalRtt replaced by totalRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-totalroundtriptime
- RTCIceCandidatePairStats.currentRtt replaced by currentRoundTripTime: https://w3c.github.io/webrtc-stats/#dom-rtcicecandidatepairstats-currentroundtriptime

NOTRY=True
BUG= chromium:627816 ,  chromium:657854 ,  chromium:657855 ,  chromium:657856 ,  chromium:632723 

Review-Url: https://codereview.chromium.org/2590293004
Cr-Commit-Position: refs/heads/master@{#441073}

[modify] https://crrev.com/a3a849d6f9efef1f90688ef3d11f8ca75618ac3a/chrome/test/data/webrtc/peerconnection_getstats.js

Comment 12 by anatolid@chromium.org, Jan 23 2017

Labels: -M-57 M-58
Bumping this to M58. Please correct if that's wrong.

Comment 13 by hbos@chromium.org, Jan 26 2017

Labels: -M-58
Mergedinto: webrtc:7063
Status: Duplicate (was: Started)
This stats dictionary is partially supported (see landed CLs in this thread).
To better track what's left, a webrtc bug has been created to track the remaining work related to this dictionary - merging into that one.
►

Sign in to add a comment