New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632720 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Scale ARC custom notification to fit

Project Member Reported by xiy...@chromium.org, Jul 29 2016

Issue description

Chromium part for http://b/30374625

If arc notification size does not match chrome notification surface size, scale it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/589b2256f24ac204c3fdc17a333aebeac3eb7c07

commit 589b2256f24ac204c3fdc17a333aebeac3eb7c07
Author: xiyuan <xiyuan@chromium.org>
Date: Fri Jul 29 13:41:21 2016

arc: Scale notification surface to fit

BUG= 632720 
BUG=b/30374625
TEST=Manual. Increase resolution and custom notification should always fill
    chrome notification space.

Review-Url: https://codereview.chromium.org/2187363002
Cr-Commit-Position: refs/heads/master@{#408630}

[modify] https://crrev.com/589b2256f24ac204c3fdc17a333aebeac3eb7c07/ui/arc/notification/arc_custom_notification_view.cc

Labels: Merge-Request-53 M-53

Comment 3 by dimu@chromium.org, Aug 1 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 1 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fb2aa14579ee9cbf7c80252a7b31135649c9f1a

commit 5fb2aa14579ee9cbf7c80252a7b31135649c9f1a
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Mon Aug 01 16:51:45 2016

Mrege "arc: Scale notification surface to fit"

> BUG= 632720 
> BUG=b/30374625
> TEST=Manual. Increase resolution and custom notification should always fill
>     chrome notification space.
>
> Review-Url: https://codereview.chromium.org/2187363002
> Cr-Commit-Position: refs/heads/master@{#408630}
> (cherry picked from commit 589b2256f24ac204c3fdc17a333aebeac3eb7c07)

Review URL: https://codereview.chromium.org/2197283002 .

Cr-Commit-Position: refs/branch-heads/2785@{#433}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/5fb2aa14579ee9cbf7c80252a7b31135649c9f1a/ui/arc/notification/arc_custom_notification_view.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Sign in to add a comment