New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632716 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 587995



Sign in to add a comment

"onshippingaddresschange" is not fired if requestShipping is true and there one selected shippingOption

Project Member Reported by sanjoy....@samsung.com, Jul 29 2016

Issue description

On the current chrome implementation
"onshippingaddresschange" is not fired if requestShipping is true and there one selected shippingOption

the event is fired only if requestShipping is true and there are shippingOptions but nothing is selected.

 
Cc: zkoch@chromium.org
This behavior is how I've designed it. The browser vendors are currently discussing whether this behavior is conformant to spec. Let's not change it until we come to an agreement.

Comment 2 by zkoch@chromium.org, Jul 29 2016

This is not conformant. We should change. 
Status: Assigned (was: Untriaged)
Will do.
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26266594edf7704a496236ed58fe6f2a9b667d74

commit 26266594edf7704a496236ed58fe6f2a9b667d74
Author: rouslan <rouslan@chromium.org>
Date: Tue Aug 16 01:18:23 2016

Always trigger 'shippingaddresschange' event.

If the user is changing their shipping address, fire the
'shippingaddresschange' event unconditionally to better comply with the
spec: "The shipping address changed algorithm runs when the user provides a
new shipping address."

https://w3c.github.io/browser-payment-api/#shipping-address-changed-algorithm

BUG= 632716 

Review-Url: https://codereview.chromium.org/2236933007
Cr-Commit-Position: refs/heads/master@{#412122}

[modify] https://crrev.com/26266594edf7704a496236ed58fe6f2a9b667d74/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/26266594edf7704a496236ed58fe6f2a9b667d74/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
[modify] https://crrev.com/26266594edf7704a496236ed58fe6f2a9b667d74/chrome/test/data/android/payments/free_shipping.js

Status: Fixed (was: Started)

Sign in to add a comment