New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 632710 link

Starred by 2 users
Status: WontFix
Owner:
█ bradnelson@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
█ mkwst@chromium.org
rdevlin....@chromium.org
nyerramilli@chromium.org
█ msrchandra@chromium.org
alex...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Content of extension overlay disappears on typing any text in search box in "Handy maps" extension

Reported by adha...@etouch.net, Jul 29 2016 
Chrome Version:54.0.2811.0 b19949388aaceb1d0dc2b48ad00b272dd1c72af5-refs/heads/master@{#408553} (32/64-bit)
OS : Windows (7,8,8.1,10),Mac OS X(10.10.5, 10.11.4)

Test url:https://chrome.google.com/webstore/detail/handy-maps/gamlmgkgpkoacendnhjdlccbijpkflbf?utm_source=chrome-ntp-icon

What steps will reproduce the problem?
(1)Launch chrome,navigate to above url and click on 'Add to Chrome'
(2)Click on extension icon, in Extensions overlay.
(3)Type any text in search box,press enter and observe.(Kindly refer the video)

Actual:Content of extension overlay disappears on typing any text in search box.

Expected:Content of extension overlay should not not disappear on typing any text in search box.

This is a Regression issue broken in M-51,below is the Narrow bisect info:
https://chromium.googlesource.com/chromium/src/+log/e88911273a84b9b621432fcb584825c9f728d3ce..fe3252084adfdc683503e9c7fff8d2b04863d1d8?pretty=fuller&n=10000 

Suspecting:r378764?

Good build:51.0.2665.0
Bad build:51.0.2666.0

Kindly help to re-assign if your change is not the cause for this issue
Actual result.mp4
702 KB View Download
Expected result.mp4
596 KB View Download

Comment 1 by rdevlin....@chromium.org, Jul 29 2016

Cc: alex...@chromium.org
I doubt that adding fuzzing caused this to regress.  At first glance, I would have thought this was an extension bug, but then we wouldn't have a regression range.

Looking through the possibilities, revision 77f6ed50529fb670db4cb3989bae5d93515a33a5 seems a little suspect - but that's mostly just because it does complicated blink stuff I don't really grok and sounds like it potentially could have impacted this.  Alex, any idea if your patch could cause this behavior change?  (And if so, bug, or WAI?)

Comment 2 by alex...@chromium.org, Aug 4 2016

Cc: mkwst@chromium.org
Yes, I think it's my patch, and it's WAI.

I've tried this extension out, and I suspect that the overlay disappears due to X-Frame-Options.  I see the following console message after following the repro steps on a debug ToT build: 

[17335:17335:0803/164748:INFO:CONSOLE(0)] "Refused to display 'http://maps.google.com/maps?f=q&source=s_q&hl=en&geocode=&q=asdf&ie=UTF8&z=auto&output=embed&t=m&iwloc=near' in a frame because it set 'X-Frame-Options' to 'SAMEORIGIN'.", source: http://maps.google.com/maps?f=q&source=s_q&hl=en&geocode=&q=asdf&ie=UTF8&z=auto&output=embed&t=m&iwloc=near (0)

Previously, navigating a frame to a URL blocked by XFO would leave the old page visible, but after my CL in #1 we now behave as if a blank page was loaded instead, which is more spec-compliant.  So, this is working as intended: I don't think you should be relying on a navigation blocked by XFO keeping the old page visible.  CC-ing mkwst@ as FYI.

Comment 3 by mkwst@chromium.org, Aug 4 2016

Status: WontFix (was: Assigned)
I agree with alexmos@. Note also that if/when we re-land the patches that move X-F-O processing to the browser, the blank page will be replaced with a friendly error page instead. Either way, the user will be informed that something has gone wrong; that seems like a reasonable thing to do in the case of failed navigation.
►

Sign in to add a comment