Issue metadata
Sign in to add a comment
|
Regression: Windows with transient parents (e.g. dialogs) have wrong scale and position in overview mode |
||||||||||||||||||||||
Issue descriptionVersion: 53.0.2785.36/8530.35.0 (Official Build) dev-channel peppy,daisy,blaze OS: Chrome os What steps will reproduce the problem? (1) Open some windows >> Now in one of the window[Settings/browser] hit "ctrl+o" to get sub dialog >> Switch to overview mode-- hit []]] and observe the window with sub dialog. Expected: Background shadow should be equally distributed when sub dialog is present. Actual: Instead it is not equally distributed, no "x" button is seen. This is a regression issue as same is working fine in 52.0.2743.85/8350.60.0 (Official Build) stable-channel daisy. @varkha: Please confirm the behavior.
,
Jul 29 2016
Able to reproduce the issue on Daisy using 53.0.2785.36/8530.35.0_Beta. Marking this issue ReleaseBlock-Stable, please modify if not appropriate.
,
Jul 29 2016
,
Jul 29 2016
It seems the regression is in M53 as well based on the bug report.
,
Jul 29 2016
Draft CL at https://codereview.chromium.org/2197773002.
,
Jul 29 2016
,
Jul 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e4a6217e4694b15ba76a51b406254e9a4f22e1e commit 0e4a6217e4694b15ba76a51b406254e9a4f22e1e Author: varkha <varkha@chromium.org> Date: Fri Jul 29 21:23:27 2016 [ash-md] Properly scales windows with transient parents in overview Previously to this CL the code was only considering the focused window when calculating scale for the overview mode transform. It needs to consider the bounding rectangle of the whole transient parent's tree. BUG= 632694 Review-Url: https://codereview.chromium.org/2197773002 Cr-Commit-Position: refs/heads/master@{#408763} [modify] https://crrev.com/0e4a6217e4694b15ba76a51b406254e9a4f22e1e/ash/common/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/0e4a6217e4694b15ba76a51b406254e9a4f22e1e/ash/common/wm/overview/scoped_transform_overview_window.h [modify] https://crrev.com/0e4a6217e4694b15ba76a51b406254e9a4f22e1e/ash/common/wm/overview/window_grid.cc [modify] https://crrev.com/0e4a6217e4694b15ba76a51b406254e9a4f22e1e/ash/common/wm/overview/window_selector_item.cc [modify] https://crrev.com/0e4a6217e4694b15ba76a51b406254e9a4f22e1e/ash/common/wm/overview/window_selector_item.h
,
Jul 29 2016
Would be great if the testers could confirm the fix on Canary and merge it in M-53 before the beta.
,
Jul 29 2016
+dhaddock@
,
Jul 29 2016
,
Jul 30 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/149ce74ddadbf5cb76ee003d3088f46363bbe014 commit 149ce74ddadbf5cb76ee003d3088f46363bbe014 Author: Valery Arkhangorodsky <varkha@chromium.org> Date: Tue Aug 02 16:01:56 2016 [ash-md] Properly scales windows with transient parents in overview Previously to this CL the code was only considering the focused window when calculating scale for the overview mode transform. It needs to consider the bounding rectangle of the whole transient parent's tree. BUG= 632694 Review-Url: https://codereview.chromium.org/2197773002 Cr-Commit-Position: refs/heads/master@{#408763} (cherry picked from commit 0e4a6217e4694b15ba76a51b406254e9a4f22e1e) Review URL: https://codereview.chromium.org/2203793003 . Cr-Commit-Position: refs/branch-heads/2785@{#468} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/149ce74ddadbf5cb76ee003d3088f46363bbe014/ash/common/wm/overview/scoped_transform_overview_window.cc [modify] https://crrev.com/149ce74ddadbf5cb76ee003d3088f46363bbe014/ash/common/wm/overview/scoped_transform_overview_window.h [modify] https://crrev.com/149ce74ddadbf5cb76ee003d3088f46363bbe014/ash/common/wm/overview/window_grid.cc [modify] https://crrev.com/149ce74ddadbf5cb76ee003d3088f46363bbe014/ash/common/wm/overview/window_selector_item.cc [modify] https://crrev.com/149ce74ddadbf5cb76ee003d3088f46363bbe014/ash/common/wm/overview/window_selector_item.h
,
Aug 12 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sc00335...@techmahindra.com
, Jul 29 2016