Create IOSChromeContentSuggestionsServiceFactory |
|||||
Issue descriptionWe want the ContentSuggestionsService to be compilable to iOS. The factory ensures that we can use it any time and that we don't accidentally introduce new dependencies that aren't available on iOS. This also allows the NTPSnippetsService (through the IOSChromeNTPSnippetsServiceFactory) to access dependencies that it has on the ContentSuggestionsService (like the ContentSuggestionsCategoryFactory).
,
Jul 29 2016
,
Aug 1 2016
,
Aug 1 2016
,
Aug 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca76f9c6a37b34de6d70b3e4e1ddb9c6f61c3041 commit ca76f9c6a37b34de6d70b3e4e1ddb9c6f61c3041 Author: pke <pke@google.com> Date: Mon Aug 01 09:41:36 2016 Create IOSChromeContentSuggestionsServiceFactory Create the factory so that the new ContentSuggestionsService is available on iOS. It is currently always disabled, but the factory ensures that the service doesn't introduce new non-iOS dependencies. Remove the IOSChromeNTPSnippetsServiceFactory because the NTPSnippetsService is now a plain provider and will not be a KeyedService anymore. It will be created by the new IOSChromeContentSuggestionsServiceFactory in the future. BUG= 632690 Owner: me Review-Url: https://codereview.chromium.org/2194793004 Cr-Commit-Position: refs/heads/master@{#408934} [modify] https://crrev.com/ca76f9c6a37b34de6d70b3e4e1ddb9c6f61c3041/ios/chrome/browser/BUILD.gn [modify] https://crrev.com/ca76f9c6a37b34de6d70b3e4e1ddb9c6f61c3041/ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm [add] https://crrev.com/ca76f9c6a37b34de6d70b3e4e1ddb9c6f61c3041/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.cc [add] https://crrev.com/ca76f9c6a37b34de6d70b3e4e1ddb9c6f61c3041/ios/chrome/browser/ntp_snippets/ios_chrome_content_suggestions_service_factory.h [delete] https://crrev.com/61557fb1951d1753e1a934ff1ffe0bfab1b40148/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc [delete] https://crrev.com/61557fb1951d1753e1a934ff1ffe0bfab1b40148/ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.h [modify] https://crrev.com/ca76f9c6a37b34de6d70b3e4e1ddb9c6f61c3041/ios/chrome/ios_chrome.gyp
,
Aug 1 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pke@google.com
, Jul 29 2016