factory: make_factory_package dies without message. |
||||||
Issue description<b>Version: <Kenneth, what is the frequency?></b> <b>OS: <please tell me it's not XP></b> What steps will reproduce the problem? (1) In a Ubuntu without cgpt installed (2) make_factory_package --test TEST_IMAGE --factory_toolkit TOOLKIT ... What is the expected output? Success, or raise error messages. What do you see instead? Some message saying that it's creating a temp test image, then nothing. The redirected error output file contains message that toolkit tries to run cgpt and fail. I'd propose following changes: 1. make_factory_package should print some ERROR earlier if it exits unexpectedly. 2. make_factory_package should pass CGPT program path correctly in PATH when calling sub programs (toolkit)
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/3c00505c75fc7d67ae81865530c12fb658e9b1e9 commit 3c00505c75fc7d67ae81865530c12fb658e9b1e9 Author: Yilun Lin <yllin@google.com> Date: Fri Feb 10 14:42:45 2017 make_factory_package: Early failure when creating factory test image. Early failure when there is no cgpt in the system PATH. If cgpt exists, set env CGPT and pass to toolkit subprogram. BUG= chromium:632629 TEST=manual test Change-Id: Iafe2b5e7474b15cfc3e9ee8a87390fe6f8498a35 Reviewed-on: https://chromium-review.googlesource.com/440784 Commit-Ready: Yilun Lin <yllin@chromium.org> Tested-by: Yilun Lin <yllin@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/3c00505c75fc7d67ae81865530c12fb658e9b1e9/setup/make_factory_package.sh [modify] https://crrev.com/3c00505c75fc7d67ae81865530c12fb658e9b1e9/py/utils/sys_utils.py
,
Feb 10 2017
Congratulations on getting your first CL merged and first issue closed :)
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hungte@chromium.org
, Jan 25 2017Owner: yllin@chromium.org
Status: Assigned (was: Untriaged)