Details:
  - MP4 with H.264 video track.
  - Natural size is 1280x720.
  - There is a 90deg rotation matrix.
  - We are rotating the frames but the natural size has not been adjusted to account for it.
  - Trivial to reproduce; affects FFmpeg software path on Linux.

cosminmalutan@: Do you mind if I attach the .mp4 file here for easier debugging?

emircan@: I believe you've been through this code recently, perhaps you already have some idea what is wrong? (Feel free to assign back to me.)

I'm pretty excited to think about the number of my customers that are about to blow up my support channels.  


Is this something you think a hotfix would be pushed for?

sanders@, you probably remember this bug https://bugs.chromium.org/p/webrtc/issues/detail?id=6069. That is related to MediaStream from remote client that goes through webmediaplayer_ms. This bug is just video playback which goes through webmediaplayer_impl. I am not very familiar with that area unfortunately, and I will assign it back to you in case you can find somebody. The issue can be somewhere within layer tree or here in webmediaplayer_impl.  https://cs.chromium.org/chromium/src/media/blink/webmediaplayer_impl.cc?rcl=1469805843&l=1025 

Also, when trying to reproduce on ToT, I git this DCHECK: https://paste.googleplex.com/5827267225714688 

@sande... feel free to add it.

It turns out that this actually reproduces with test files that are already in our test data set (all videos with rotation metadata are affected), so I'll skip attaching any additional data.

re. hotfix: This is unlikely for M52, since the problem is not dangerous. The fix should be simple enough to merge for M53 though (which just very recently branched).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c4784280c9414e0bd4daf9f0c606f8e52de117a

commit 2c4784280c9414e0bd4daf9f0c606f8e52de117a
Author: sandersd <sandersd@chromium.org>
Date: Tue Aug 02 01:19:25 2016

Account for video rotation in OnVideoNaturalSizeChange()

This was always wrong, but now that natural size chages are always
emitted (commit 810dee4b15363fc5e1af55880afe79ebf5a1ebda) they are
causing all non-square rotated videos to render with the wrong
aspect ratio.

This CL ensures that sizes are treated the same way on this path as
in OnMetadata().

BUG= 632624 

Review-Url: https://codereview.chromium.org/2198403002
Cr-Commit-Position: refs/heads/master@{#409112}

[modify] https://crrev.com/2c4784280c9414e0bd4daf9f0c606f8e52de117a/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/2c4784280c9414e0bd4daf9f0c606f8e52de117a/media/blink/webmediaplayer_impl_unittest.cc

Your change meets the bar and is auto-approved for M53 (branch: 2785)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8899e7525aca5ca5abc49c9450fb6e395efeedb

commit f8899e7525aca5ca5abc49c9450fb6e395efeedb
Author: Dan Sanders <sandersd@chromium.org>
Date: Wed Aug 03 00:55:38 2016

Merge to M53: Account for video rotation in OnVideoNaturalSizeChange()

This was always wrong, but now that natural size chages are always
emitted (commit 810dee4b15363fc5e1af55880afe79ebf5a1ebda) they are
causing all non-square rotated videos to render with the wrong
aspect ratio.

This CL ensures that sizes are treated the same way on this path as
in OnMetadata().

BUG= 632624 

Review-Url: https://codereview.chromium.org/2198403002
Cr-Commit-Position: refs/heads/master@{#409112}
(cherry picked from commit 2c4784280c9414e0bd4daf9f0c606f8e52de117a)

Review URL: https://codereview.chromium.org/2205173002 .

Cr-Commit-Position: refs/branch-heads/2785@{#476}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/f8899e7525aca5ca5abc49c9450fb6e395efeedb/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/f8899e7525aca5ca5abc49c9450fb6e395efeedb/media/blink/webmediaplayer_impl_unittest.cc

Verified the fix on Windows 7, MAC (10.11.6) & Ubuntu Trusty (14.04) for Google Chrome Beta Version - 53.0.2785.45 

Screen-recording is attached.

TE-Verified labels are added.

@sandersd: Please change the status accordingly.

Thank you.

Deleted: 632624.mp4 690 KB

	632624.mp4 690 KB View Download

This is fixed in M53.

 Issue 632165  has been merged into this issue.

 Issue 637312  has been merged into this issue.

 Issue 637063  has been merged into this issue.