New issue
Advanced search Search tips

Issue 632617 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature



Sign in to add a comment

Make generated password copyable

Project Member Reported by dvadym@chromium.org, Jul 29 2016

Issue description

Currently the user can see a generated password in a password field in clear text, but it's not possible to copy it. It seems that there is no apparent reason for this.
 

Comment 1 by vabr@chromium.org, Jul 29 2016

Labels: Hotlist-Polish

Comment 2 by kolos@chromium.org, Mar 9 2017

Owner: kolos@chromium.org
Status: Started (was: Available)
If there is the confirmation field, but we filled the wrong field or hidden field, the user should be able to copy the generated password.

Comment 3 by kolos@chromium.org, Mar 9 2017

Labels: -Pri-3 Pri-1
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f5e4fd1fa6edfe86f3b01da639255a937c5cd20

commit 2f5e4fd1fa6edfe86f3b01da639255a937c5cd20
Author: kolos <kolos@chromium.org>
Date: Tue Mar 14 16:10:19 2017

[PasswordGeneration] Makes password fields with revealed password copyable

If there is the confirmation field, but we filled the wrong field or hidden field, the user should be able to copy the generated password.

* Dragging passwords are not allowed at this point. PasswordGenerationAgent should listen for dragging events. Now it listens only for text changes. Let's see if dragging password is needed.
* Copying DHTML are not allowed. Passwords is just text.

BUG= 632617 

Review-Url: https://codereview.chromium.org/2740823003
Cr-Commit-Position: refs/heads/master@{#456719}

[modify] https://crrev.com/2f5e4fd1fa6edfe86f3b01da639255a937c5cd20/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/2f5e4fd1fa6edfe86f3b01da639255a937c5cd20/third_party/WebKit/Source/core/editing/EditorTest.cpp

Comment 5 by kolos@chromium.org, Mar 14 2017

Status: Fixed (was: Started)

Sign in to add a comment