New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632603 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Weird behaviour of Profile icon on switch person overlay is seen after clicking on fullscreen icon.

Reported by lpa...@etouch.net, Jul 29 2016

Issue description

Chrome Version: 54.0.2811.0 (Official Build)b19949388aaceb1d0dc2b48ad00b272dd1c72af5-refs/heads/master@{#408553} 32/64-bit.
OS: Mac (10.10.5)(10.11.4), Linux(Ubuntu 14.04 LTS) 

Steps:
1. Launch chrome, click on avatar icon and select 'Switch person'.
2. Click on fullscreen icon seen at top L.H.S of browser window and observe.

Actual: Weird behaviour of Profile icon on switch person overlay is seen after clicking on fullscreen icon i.e it seems to be shaky after clicking on fullscreen icon.
 
Expected: No such behaviour should be seen i.e it should not be shaky after clicking on fullscreen icon.
 
This is a regression issue broken in M-54, will soon update the bisect info.
 

Comment 1 by lpa...@etouch.net, Jul 29 2016

Cc: roc...@chromium.org
Labels: hasbisect
Owner: enne@chromium.org
Status: Assigned (was: Unconfirmed)
Manual Regression range
Good Build: 54.0.2809.0
Bad Build : 54.0.2810.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/a86eb14b66aec353ca5f12980f53f5c7935371b5..4a25002ddbb8aece950b4fadefea4a9ac4632ef8?pretty=fuller&n=1000

Suspecting: r408172?

Kindly help to re-assign if your change is not the cause of this issue.

Note: Issue is not seen on Windows(7,8,8.1,10)
Actual_Profile.mov
1.4 MB Download
Expected_Profile.mov
1.3 MB Download

Comment 2 by lpa...@etouch.net, Jul 29 2016

Labels: OS-Windows
Correction: Issue is also seen on Windows(7,8,8.1,10).
Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.

Comment 4 by ajha@chromium.org, Aug 3 2016

Cc: sky@chromium.org
Issue is still reproducible on the latest canary(54.0.2816.4) on Mac OS 10.11.5.

Cc'ing sky@ as well for https://codereview.chromium.org/2184613005 in the regression range for more inputs.


Comment 5 by enne@chromium.org, Aug 3 2016

This is from my change.  I will look into it next week.

Comment 6 by ajha@chromium.org, Aug 10 2016

enne@: Is there any update on this Blocker issue?

Appreciate your response!

Comment 7 by enne@chromium.org, Aug 10 2016

Labels: -Pri-1 -ReleaseBlock-Stable Pri-2
No, there is no update.  I don't think it is P1 or blocking, however.  It is a slight jank in content update.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee0504e307d6ed18a94a96eae8a4b57adcff4b11

commit ee0504e307d6ed18a94a96eae8a4b57adcff4b11
Author: enne <enne@chromium.org>
Date: Fri Aug 12 22:49:41 2016

Fix jank during mac resize

Allow SetNeedsBeginFrames messages to be handled on Mac during resize.
If this message is not handled, then the renderer says that it needs
frames but the message is ignored because of the resize lock.  Then, the
browser never sends begin frame messages and the renderer then never is
able to produce a frame.  This means that it can't produce a frame of
the right size before the resize lock times out and there's jank on
screen.

R=ccameron@chromium.org,sievers@chromium.org
BUG= 632603 

Review-Url: https://codereview.chromium.org/2246613002
Cr-Commit-Position: refs/heads/master@{#411806}

[modify] https://crrev.com/ee0504e307d6ed18a94a96eae8a4b57adcff4b11/content/browser/renderer_host/render_message_filter.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/403810b6f9fe48ae77b6f19fc2c7e413e2088a00

commit 403810b6f9fe48ae77b6f19fc2c7e413e2088a00
Author: enne <enne@chromium.org>
Date: Wed Aug 17 19:51:15 2016

Revert of Fix jank during mac resize (patchset #2 id:20001 of https://codereview.chromium.org/2246613002/ )

Reason for revert:
Causes fullscreen flash videos to be all white on Mac

BUG=638561

Original issue's description:
> Fix jank during mac resize
>
> Allow SetNeedsBeginFrames messages to be handled on Mac during resize.
> If this message is not handled, then the renderer says that it needs
> frames but the message is ignored because of the resize lock.  Then, the
> browser never sends begin frame messages and the renderer then never is
> able to produce a frame.  This means that it can't produce a frame of
> the right size before the resize lock times out and there's jank on
> screen.
>
> R=ccameron@chromium.org,sievers@chromium.org
> BUG= 632603 
>
> Committed: https://crrev.com/ee0504e307d6ed18a94a96eae8a4b57adcff4b11
> Cr-Commit-Position: refs/heads/master@{#411806}

TBR=asvitkine@chromium.org,ccameron@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 632603 

Review-Url: https://codereview.chromium.org/2255893002
Cr-Commit-Position: refs/heads/master@{#412615}

[modify] https://crrev.com/403810b6f9fe48ae77b6f19fc2c7e413e2088a00/content/browser/renderer_host/render_message_filter.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5ce61d4966237e3572f3048a6ea39c7ba7d7c64

commit e5ce61d4966237e3572f3048a6ea39c7ba7d7c64
Author: enne <enne@chromium.org>
Date: Tue Aug 23 00:25:04 2016

Fix jank during mac resize

Allow SetNeedsBeginFrames messages to be handled on Mac during resize.
If this message is not handled, then the renderer says that it needs
frames but the message is ignored because of the resize lock.  Then, the
browser never sends begin frame messages and the renderer then never is
able to produce a frame.  This means that it can't produce a frame of
the right size before the resize lock times out and there's jank on
screen.

R=ccameron@chromium.org,sievers@chromium.org
BUG= 632603 ,638561

Review-Url: https://codereview.chromium.org/2246613002
Cr-Commit-Position: refs/heads/master@{#413601}

[modify] https://crrev.com/e5ce61d4966237e3572f3048a6ea39c7ba7d7c64/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/e5ce61d4966237e3572f3048a6ea39c7ba7d7c64/content/browser/renderer_host/render_widget_host_impl.cc

Project Member

Comment 11 by sheriffbot@chromium.org, Dec 19 2016

Status: Available (was: Assigned)
--Chrome Identity automated triaging--

This bug is Assigned and has gone one month without any activity, so it is being moved to Available to indicate that it is not actively being worked on. If you are working on this bug, please mark yourself as the owner and move back to Assigned. Please see https://goo.gl/78kbny for more details. Please remove the Services>SignIn or UI>Browser>Profiles components if this bug isn't related to Chrome Identity.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 12 by enne@chromium.org, Mar 20 2017

Status: Fixed (was: Available)
Belatedly marking this as fixed after those patches above landed.

Sign in to add a comment