New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632591 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

In md-settings, text entered in search box appears faint.

Reported by vvishwak...@etouch.net, Jul 29 2016

Issue description

Version: 54.0.2811.0 b19949388aaceb1d0dc2b48ad00b272dd1c72af5-refs/heads/master@{#408553} (32/64-bit)
OS: Windows (7,8,10), Linux (14.04 LTS), Mac (10.10.5, 10.11.5)

What steps will reproduce the problem?
1) Launch chrome and go to chrome://md-settings/managePasswords.
2) Enter some text in search box and observe the text color.

Text entered in search box appears faint.

Text entered in search box should not be faint.

This is a Non-Regression issue seen from M-54 series (54.0.2811.0)

Note: This feature is not available in previous builds.


 
 
settings_search.jpg
111 KB View Download
Labels: Proj-MaterialDesign-WebUI
Status: Untriaged (was: Unconfirmed)
Over to Proj-MaterialDesign-WebUI MD settings team for triage.
Labels: -M-54 Hotlist-MD-Settings-PasswordsForms
Owner: hcarmona@chromium.org
Status: Assigned (was: Untriaged)
Cc: bettes@chromium.org
@bettes should the text be black when searching? 
Owner: bettes@chromium.org

Comment 5 by bettes@chromium.org, Aug 15 2016

Owner: hcarmona@chromium.org
The input text should be darker, Paper Grey 800
Status: Started (was: Assigned)
Attached screenshots with input text at paper grey 800.

No change for the placeholder text (google grey 500).
darker-search.png
50.7 KB View Download
placeholder-no-change.png
58.6 KB View Download
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69f435b4d3495f9cb060df79d335393fc5f5cf8a

commit 69f435b4d3495f9cb060df79d335393fc5f5cf8a
Author: hcarmona <hcarmona@chromium.org>
Date: Tue Aug 23 22:23:31 2016

Change the subpage search text color to --paper-gray-800.

Screenshots in bug.
BUG= 632591 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2272463002
Cr-Commit-Position: refs/heads/master@{#413861}

[modify] https://crrev.com/69f435b4d3495f9cb060df79d335393fc5f5cf8a/chrome/browser/resources/settings/settings_page/settings_subpage_search.html

Status: Fixed (was: Started)
Forgot to close this issue. Fixed.

Sign in to add a comment