New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632585 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Crash in webrtc::rtcp::TransportFeedback::ParseFrom

Project Member Reported by ClusterFuzz, Jul 29 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4527759888220160

Fuzzer: libfuzzer_rtcp_receiver_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: UNKNOWN
Crash Address: 0x03e9000040f8
Crash State:
  webrtc::rtcp::TransportFeedback::ParseFrom
  webrtc::RTCPUtility::RTCPParserV2::ParseFBCommon
  webrtc::RTCPUtility::RTCPParserV2::IterateTopLevel
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=408389:408457

Minimized Testcase (2.68 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95DtwqrybS6FCN8xSLFyyAYjGxc7RC9c5iwhC3s-tmmwEplwCK6ykR3cQqASz_MMoovpbeBaR9fiMKn--E9x5WFt5JlgiA7_xLh0Ep1nh1LxHCfbezaNedWmNGSXlWbYgX-wPNOUdfI02ZWpzWU2tvZwMFbtQ?testcase_id=4527759888220160

Additional requirements: Requires Gestures

Filer: rnimmagadda

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Cc: niklas.enbom@webrtc.org andrew@webrtc.org
Components: Blink>WebRTC Tools>Test>FindIt>CorrectResult
Labels: -Pri-1 -Type-Bug Findit-for-crash M-54 Te-Logged Pri-2 Type-Bug-Regression
Suspecting:

Author: andrew@webrtc.org
Project: chromium-webrtc
Changelist: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+/b015cbede88899f67a53fbbe581b02ce8e327949
Time: Mon Oct 22 18:19:23 2012
The CL last changed line 98 of file rtcp_utility.cc, which is stack frame 5.

@andrew: Could you please look into this issue.

Thank you.
Cc: sprang@chromium.org

Comment 3 by sprang@chromium.org, Jul 29 2016

Cc: -andrew@webrtc.org holmer@chromium.org
Owner: danilchap@chromium.org
+danil could you have a look?
Status: Started (was: Untriaged)
it crash at a DCHECK that verifies sizes of chunks and symbols in the rtcp feedback messages sum up to size of the rtcp packet. i.e. that padding is maximum 3 bytes.
While it better be true for created packets, it can't be assumed for packets arrived from network.

Best solution seems to remove this particular DCHECK - it make assumption on input data that shouldn't have any assumption.

Project Member

Comment 6 by ClusterFuzz, Aug 1 2016

ClusterFuzz has detected this issue as fixed in range 408588:408608.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4527759888220160

Fuzzer: libfuzzer_rtcp_receiver_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: UNKNOWN
Crash Address: 0x03e9000040f8
Crash State:
  webrtc::rtcp::TransportFeedback::ParseFrom
  webrtc::RTCPUtility::RTCPParserV2::ParseFBCommon
  webrtc::RTCPUtility::RTCPParserV2::IterateTopLevel
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=408389:408457
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=408588:408608

Minimized Testcase (2.68 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95DtwqrybS6FCN8xSLFyyAYjGxc7RC9c5iwhC3s-tmmwEplwCK6ykR3cQqASz_MMoovpbeBaR9fiMKn--E9x5WFt5JlgiA7_xLh0Ep1nh1LxHCfbezaNedWmNGSXlWbYgX-wPNOUdfI02ZWpzWU2tvZwMFbtQ?testcase_id=4527759888220160

Additional requirements: Requires Gestures

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Aug 1 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: -Pri-2 ClusterFuzz-Wrong Pri-3
Status: Started (was: Verified)
CL that removes the DCHECK causing the issue has not landed yet.
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/webrtc.git/+/837a1707ae5aed19306f2bd9b4b0927901247b68

commit 837a1707ae5aed19306f2bd9b4b0927901247b68
Author: Danil Chapovalov <danilchap@webrtc.org>
Date: Wed Aug 03 11:39:58 2016

Remove faulty DCHECK in rtcp::TransportFeedback::ParseFrom

BUG= chromium:632585 
R=sprang@webrtc.org

Review URL: https://codereview.webrtc.org/2196563003 .

Cr-Commit-Position: refs/heads/master@{#13622}

[modify] https://crrev.com/837a1707ae5aed19306f2bd9b4b0927901247b68/webrtc/modules/rtp_rtcp/source/rtcp_packet/transport_feedback.cc

Status: Fixed (was: Started)
Rolled into chromium with https://codereview.chromium.org/2203033007
Project Member

Comment 11 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -ClusterFuzz-Wrong
We have made a bunch of changes on ClusterFuzz side, so resetting ClusterFuzz-Wrong label.

Sign in to add a comment