New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632575 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 625332



Sign in to add a comment

Regression : Unnecessary Scrollbar is seen in SIGN OUT overlay of chrome://md-settings

Project Member Reported by mm00333...@techmahindra.com, Jul 29 2016

Issue description

Version: 54.0.2811.0
OS:Windows

What steps will reproduce the problem?
1. Launch chrome, click on Avatar icon and sign in to chrome.
2. Go to chrome://md-settings and click on SIGN OUT button, observe.

Actual : Instead  Unnecessary Scrollbar is seen in SIGN OUT overlay of  chrome://md-settings 
Expected :  Unnecessary Scrollbar should not be seen in SIGN OUT overlay of  chrome://md-settings 

This is a Regression issue broken in 'M-54'
 will provide Bisect info soon 

Manual Good and Bad Builds:
Good Build : 54.0.2810.2
Bad Build : 54.0.2811.0

 

Comment 1 by ajha@chromium.org, Jul 29 2016

Labels: Needs-Bisect OS-Mac
Status: Untriaged (was: Unconfirmed)
Reproducible on the latest canary(54.0.2811.0) on Mac OS 10.11.5 as well.
Issue is also seen on Linux OS
Attaching screenshot for reference
Actual_Scrollbar.png
146 KB View Download
Labels: -Needs-Bisect OS-Linux
Owner: skobes@chromium.org
Status: Assigned (was: Untriaged)
Note : Unable to provide narrow bisect as sign in to chrome in chromium builds is not possible, hence providing Manual change log info.

MANUAL CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/54.0.2810.0..54.0.2811.0?pretty=fuller&n=10000

Suspecting https://codereview.chromium.org/2184333002 from Manual Changelog

@skobes :  Please feel free to re-assign if its not related to your change
Expected_Overlay.png
143 KB View Download

Comment 4 by skobes@chromium.org, Jul 29 2016

Cc: szager@chromium.org
Owner: cbiesin...@chromium.org
My change is not related.

@cbiesinger, could this be related to any recent PLSA/flexbox changes (like  issue 629491 )?
Cc: cbiesin...@chromium.org
Components: UI>Browser>WebUI
Owner: dpa...@chromium.org
Got a better bisect:

You are probably looking for a change made after 408491 (known good), but no later than 408496 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/7ba074a071a39e964057dd02d75b8c90fe0c5e01..7947ccd5754451960f0bf18f3b5401dc5ffeedb8

Which very likely points to this checkin by dpapad:
https://chromium.googlesource.com/chromium/src/+/0501e1b4e707a2d7f4a0525f2f9b0b1ba2dac644

Reassigning.

Comment 6 by dpa...@chromium.org, Jul 29 2016

Blocking: 625332
Labels: Proj-MaterialDesign-WebUI

Comment 7 by dpa...@chromium.org, Jul 30 2016

Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b0d782e72062872102fcb7f4a2fc71c5c625cd0b

commit b0d782e72062872102fcb7f4a2fc71c5c625cd0b
Author: dpapad <dpapad@chromium.org>
Date: Sat Jul 30 02:14:52 2016

MD Settings: Remove unnecessary scrollbar from Sign out dialog.

BUG= 632575 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2196613003
Cr-Commit-Position: refs/heads/master@{#408842}

[modify] https://crrev.com/b0d782e72062872102fcb7f4a2fc71c5c625cd0b/chrome/browser/resources/settings/people_page/people_page.html

Status: Fixed (was: Started)
Cc: ashej...@chromium.org
Labels: TE-Verified-54.0.2816.0 TE-Verified-M54
Retested the above issue on All-OS(Windows, Mac 10.11.6 & Ubuntu 14.04) with chrome version - 54.0.2816.0 & un-necessary scroll bar is not seen on md-settings page.

Hence marking the same as TE-Verified-54.0.2816.0.

Attach is the print-screen below.

Thank you!
Screenshot from 2016-08-02 12:58:23.png
206 KB View Download

Sign in to add a comment