New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632574 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Gmail and Images link button does not appear properly in print preview.

Reported by adha...@etouch.net, Jul 29 2016

Issue description

Chrome Version : 54.0.2811.0 b19949388aaceb1d0dc2b48ad00b272dd1c72af5-refs/heads/master@{#408553} 32/64 bit
OS:Windows (7,8,8.1,10)

Test URL: www.google.com

What steps will reproduce the problem?
(1)Launch and navigate to above URL.
(2)Press ctrl+P and observe

Actual: Gmail and Images link button does not appear properly in print preview.
Expected: Gmail and Images link should appear properly in print preview.

This is a regression issue broken in 'M-54',will soon update other info.
 

Comment 1 by adha...@etouch.net, Jul 29 2016

Labels: hasbisect OS-Mac
Owner: xidac...@chromium.org
Status: Assigned (was: Unconfirmed)
Good Build : 54.0.2810.2
Bad Build : 54.0.2811.0

Narrow Bisect URL : 
https://chromium.googlesource.com/chromium/src/+log/770c0cfd44f0a28c07c0f76ad6059f334d056b02..75e2993f8a310d9f0f1969c6a818f59c94354fc4?pretty=fuller&n=100

Suspecting : r408402?

Note : Above issue is also seen on Mac(10.10.5, 10.11.4) OS and will soon update Linux(14.04 LTS) info.
Kindly help to reassign if your change is not the cause of thiss issue.
Actual_Preview.mp4
349 KB View Download
Expected_Preview.mp4
211 KB View Download

Comment 2 by adha...@etouch.net, Jul 29 2016

Labels: OS-Linux
Cc: xidac...@chromium.org
Owner: halcanary@chromium.org
My change is still under an experimental flag and I checked, the page doesn't use ImageBitmap.

halcanary@: I saw that you had two changes:
SkPDF: refactor font subset: fewer copies
SkPdf: SkPDFFormXObject de-class-ified.

This issue looks like font related, could you please take a look.
Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.
Status: Started (was: Assigned)
Thanks for the report:

Attached is my minimized test case.

I'm working on it.
g.html
175 bytes View Download
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f21e58de30c04701c063b0695cdbfd8c294b8a23

commit f21e58de30c04701c063b0695cdbfd8c294b8a23
Author: skia-deps-roller <skia-deps-roller@chromium.org>
Date: Fri Jul 29 18:49:41 2016

Roll src/third_party/skia/ 1e8761809..5db44aa2a (6 commits).

https://chromium.googlesource.com/skia.git/+log/1e8761809d76..5db44aa2aa4a

$ git log 1e8761809..5db44aa2a --date=short --no-merges --format='%ad %ae %s'
2016-07-29 mtklein GN: components as static library instead of source set
2016-07-29 msarett Fix various SkColorSpace bugs
2016-07-29 egdaniel Use HashSet instead of Dynamic hash for tracking vulkan resources
2016-07-29 fmalita [SVGDom] Parse style attributes
2016-07-29 halcanary SkPDF: flip saveLayer rightside up
2016-07-29 mtklein GN: quick doc

BUG= 632574 

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=tomhudson@google.com

Review-Url: https://codereview.chromium.org/2193593004
Cr-Commit-Position: refs/heads/master@{#408700}

[modify] https://crrev.com/f21e58de30c04701c063b0695cdbfd8c294b8a23/DEPS

Comment 9 by ajha@chromium.org, Aug 2 2016

Labels: TE-Verified-M54 TE-Verified-54.0.2816.0
Verified the fix on the latest M-54(54.0.2816.0) on Windows-7, Mac OS 10.11.5 and Linux Ubuntu 14.04 and this is working as intended. Attached is the screen-shot.


Adding the verified label therefore.
632574.png
142 KB View Download

Comment 10 by ajha@chromium.org, Aug 10 2016

halcanary@: Please close the issue as the fix is working as intended and verified in C#9.

Comment 11 by ajha@chromium.org, Aug 22 2016

Status: Fixed (was: Started)
Marking the issue as the Fixed as the fix has landed and verified.

Sign in to add a comment