Regression:Gmail and Images link button does not appear properly in print preview.
Reported by
adha...@etouch.net,
Jul 29 2016
|
|||||||
Issue descriptionChrome Version : 54.0.2811.0 b19949388aaceb1d0dc2b48ad00b272dd1c72af5-refs/heads/master@{#408553} 32/64 bit OS:Windows (7,8,8.1,10) Test URL: www.google.com What steps will reproduce the problem? (1)Launch and navigate to above URL. (2)Press ctrl+P and observe Actual: Gmail and Images link button does not appear properly in print preview. Expected: Gmail and Images link should appear properly in print preview. This is a regression issue broken in 'M-54',will soon update other info.
,
Jul 29 2016
,
Jul 29 2016
My change is still under an experimental flag and I checked, the page doesn't use ImageBitmap. halcanary@: I saw that you had two changes: SkPDF: refactor font subset: fewer copies SkPdf: SkPDFFormXObject de-class-ified. This issue looks like font related, could you please take a look.
,
Jul 29 2016
Adding RB Label as this is a recent Regression. Please remove if not required. Thank You.
,
Jul 29 2016
Thanks for the report: Attached is my minimized test case. I'm working on it.
,
Jul 29 2016
I broke this with: https://skia.googlesource.com/skia/+/4b1e17e test: https://fiddle.skia.org/c/@crbug_632574 fix: https://crrev.com/2197623002
,
Jul 29 2016
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/5abbb44f682038abe01b8ee63fb22439af861dda commit 5abbb44f682038abe01b8ee63fb22439af861dda Author: halcanary <halcanary@google.com> Date: Fri Jul 29 15:41:33 2016 SkPDF: flip saveLayer rightside up Broken in https://skia.googlesource.com/skia/+/4b1e17e BUG= 632574 TBR=tomhudson@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2197623002 Review-Url: https://codereview.chromium.org/2197623002 [modify] https://crrev.com/5abbb44f682038abe01b8ee63fb22439af861dda/src/pdf/SkPDFDevice.cpp [modify] https://crrev.com/5abbb44f682038abe01b8ee63fb22439af861dda/src/pdf/SkPDFFormXObject.cpp [modify] https://crrev.com/5abbb44f682038abe01b8ee63fb22439af861dda/src/pdf/SkPDFFormXObject.h [modify] https://crrev.com/5abbb44f682038abe01b8ee63fb22439af861dda/src/pdf/SkPDFShader.cpp
,
Jul 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f21e58de30c04701c063b0695cdbfd8c294b8a23 commit f21e58de30c04701c063b0695cdbfd8c294b8a23 Author: skia-deps-roller <skia-deps-roller@chromium.org> Date: Fri Jul 29 18:49:41 2016 Roll src/third_party/skia/ 1e8761809..5db44aa2a (6 commits). https://chromium.googlesource.com/skia.git/+log/1e8761809d76..5db44aa2aa4a $ git log 1e8761809..5db44aa2a --date=short --no-merges --format='%ad %ae %s' 2016-07-29 mtklein GN: components as static library instead of source set 2016-07-29 msarett Fix various SkColorSpace bugs 2016-07-29 egdaniel Use HashSet instead of Dynamic hash for tracking vulkan resources 2016-07-29 fmalita [SVGDom] Parse style attributes 2016-07-29 halcanary SkPDF: flip saveLayer rightside up 2016-07-29 mtklein GN: quick doc BUG= 632574 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=tomhudson@google.com Review-Url: https://codereview.chromium.org/2193593004 Cr-Commit-Position: refs/heads/master@{#408700} [modify] https://crrev.com/f21e58de30c04701c063b0695cdbfd8c294b8a23/DEPS
,
Aug 2 2016
Verified the fix on the latest M-54(54.0.2816.0) on Windows-7, Mac OS 10.11.5 and Linux Ubuntu 14.04 and this is working as intended. Attached is the screen-shot. Adding the verified label therefore.
,
Aug 10 2016
halcanary@: Please close the issue as the fix is working as intended and verified in C#9.
,
Aug 22 2016
Marking the issue as the Fixed as the fix has landed and verified. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by adha...@etouch.net
, Jul 29 2016Owner: xidac...@chromium.org
Status: Assigned (was: Unconfirmed)
349 KB
349 KB View Download
211 KB
211 KB View Download