New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 632572 link

Starred by 3 users
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Jul 2016
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 625332



Sign in to add a comment

Regression : Weird black border is seen around 'delete' confirmation bubble in md-history.

Reported by yfulgaon...@etouch.net, Jul 29 2016 
Chrome version : 54.0.2811.0 b19949388aaceb1d0dc2b48ad00b272dd1c72af5-refs/heads/master@{#408553} 32/64 bit
OS :  Windows (7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome, visit any web page and generate some history records.
2. Go to chrome://history, select any history record and click on 'delete' button, observe the confirmation bubble.

Actual : Weird black border is seen around confirmation bubble.
Expected : Delete confirmation bubble should be seen properly.

This is a regression issue broken in 'M-54', below is the Manual regression and soon update other info.
Good Build : 54.0.2810.2
Bad Build : 54.0.2811.0

Comment 1 by yfulgaon...@etouch.net, Jul 29 2016

Labels: hasbisect OS-Mac
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow Bisect URL : 
https://chromium.googlesource.com/chromium/src/+log/63229c8439700d37c78d7d0db66b54d968e9becd..21e70f121e72154c9891b061e9724ef30e1aecb9?pretty=fuller&n=10000

Suspecting : r408495 from Narrow Bisect

Note : Above issue is also seen on Mac(10.10.5, 10.11.4) OS and will soon update Linux(14.04 LTS) info.
Act_history_bubble.png
45.4 KB View Download

Comment 2 by yfulgaon...@etouch.net, Jul 29 2016

Labels: OS-Linux

Comment 3 by dpa...@chromium.org, Jul 29 2016

Cc: dpa...@chromium.org
 Issue 632576  has been merged into this issue.

Comment 4 by dpa...@chromium.org, Jul 29 2016

Blocking: 625332

Comment 5 by dbeam@chromium.org, Jul 29 2016

Owner: dbeam@chromium.org
i think i understand what's going on here

Comment 6 by dbeam@chromium.org, Jul 29 2016

Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3493f67572865852a8b9b2af905d97d3375eefe

commit e3493f67572865852a8b9b2af905d97d3375eefe
Author: dbeam <dbeam@chromium.org>
Date: Fri Jul 29 18:03:18 2016

MD History: fix typo and dialog inheritance

R=dpapad@chromium.org
BUG= 632572 , 632602 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2198463002
Cr-Commit-Position: refs/heads/master@{#408688}

[modify] https://crrev.com/e3493f67572865852a8b9b2af905d97d3375eefe/chrome/browser/resources/md_history/list_container.html

Comment 8 by dbeam@chromium.org, Jul 29 2016

Status: Fixed (was: Started)

Comment 9 by ajha@chromium.org, Aug 2 2016

Labels: TE-Verified-M54 TE-Verified-54.0.2816.0
Verified the fix on the latest M-54(54.0.2816.0) on Windows-7, Mac OS 10.11.5 and Linux Ubuntu 14.04. Attached is the screenshot of the same.

No black border is seen around the delete confirmation bubble.
632572.png
163 KB View Download
►

Sign in to add a comment