New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 632547 link

Starred by 2 users
Status: Fixed
Owner:
boliu@chromium.org
Closed: Jul 2016
Cc:
torne@chromium.org
█ hush@chromium.org
boliu@chromium.org
█ sgu...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CTS test testAccessHttpAuthUsernamePassword failing

Project Member Reported by yolandyan@chromium.org, Jul 29 2016 
First failed run: https://build.chromium.org/p/chromium.android/builders/Android%20WebView%20CTS%20L-MR1%20%28dbg%29/builds/14020

Exception:
@@@STEP_LOG_LINE@stdout@java.lang.IllegalStateException: This method should only be called off the UI thread@@@
@@@STEP_LOG_LINE@stdout@at com.android.webview.chromium.WebViewChromiumFactoryProvider.runBlockingFuture(WebViewChromiumFactoryProvider.java:119)@@@
@@@STEP_LOG_LINE@stdout@at com.android.webview.chromium.WebViewChromiumFactoryProvider.runOnUiThreadBlocking(WebViewChromiumFactoryProvider.java:141)@@@
@@@STEP_LOG_LINE@stdout@at com.android.webview.chromium.WebViewChromiumFactoryProvider.getWebViewDatabase(WebViewChromiumFactoryProvider.java:541)@@@
@@@STEP_LOG_LINE@stdout@at android.webkit.WebViewDatabase.getInstance(WebViewDatabase.java:39)@@@
@@@STEP_LOG_LINE@stdout@at android.webkit.cts.WebViewTest.testAccessHttpAuthUsernamePassword(WebViewTest.java:1207)@@@
@@@STEP_LOG_LINE@stdout@at java.lang.reflect.Method.invoke(Native Method)@@@
@@@STEP_LOG_LINE@stdout@at java.lang.reflect.Method.invoke(Method.java:372)@@@
@@@STEP_LOG_LINE@stdout@at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)@@@
@@@STEP_LOG_LINE@stdout@at android.test.InstrumentationTestCase.access$000(InstrumentationTestCase.java:36)@@@
@@@STEP_LOG_LINE@stdout@at android.test.InstrumentationTestCase$2.run(InstrumentationTestCase.java:189)@@@
@@@STEP_LOG_LINE@stdout@at android.app.Instrumentation$SyncRunnable.run(Instrumentation.java:1871)@@@
@@@STEP_LOG_LINE@stdout@at android.os.Handler.handleCallback(Handler.java:739)@@@
@@@STEP_LOG_LINE@stdout@at android.os.Handler.dispatchMessage(Handler.java:95)@@@
@@@STEP_LOG_LINE@stdout@at android.os.Looper.loop(Looper.java:135)@@@
@@@STEP_LOG_LINE@stdout@at android.app.ActivityThread.main(ActivityThread.java:5254)@@@
@@@STEP_LOG_LINE@stdout@at java.lang.reflect.Method.invoke(Native Method)@@@
@@@STEP_LOG_LINE@stdout@at java.lang.reflect.Method.invoke(Method.java:372)@@@
@@@STEP_LOG_LINE@stdout@at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)@@@
@@@STEP_LOG_LINE@stdout@at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)@@@

Most likely caused by this CL: https://codereview.chromium.org/2180423003

Comment 1 by boliu@chromium.org, Jul 29 2016

Cc: torne@chromium.org
frigging hell, cts uses WebViewDatabase on a background thread?

Comment 2 by boliu@chromium.org, Jul 29 2016 

on wait, that's a real bug in my CL -_-

Comment 3 by boliu@chromium.org, Jul 29 2016

Owner: boliu@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/755650c7085bb4c07bfa24112030340e2400727e

commit 755650c7085bb4c07bfa24112030340e2400727e
Author: boliu <boliu@chromium.org>
Date: Fri Jul 29 02:12:47 2016

Revert of aw: Fix FactoryProvider threading (patchset #3 id:40001 of https://codereview.chromium.org/2180423003/ )

Reason for revert:
Broke correct usage:  crbug.com/632547 

BUG= 632547 

Original issue's description:
> aw: Fix FactoryProvider threading
>
> Access thread-unsafe chromium classes on the UI thread only
>
> BUG= 630709 
>
> Committed: https://crrev.com/993fff8648f2701910b9efdbf1d35244fbf8ca73
> Cr-Commit-Position: refs/heads/master@{#408432}

TBR=torne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 630709 

Review-Url: https://codereview.chromium.org/2197433002
Cr-Commit-Position: refs/heads/master@{#408557}

[modify] https://crrev.com/755650c7085bb4c07bfa24112030340e2400727e/android_webview/glue/BUILD.gn
[modify] https://crrev.com/755650c7085bb4c07bfa24112030340e2400727e/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
[modify] https://crrev.com/755650c7085bb4c07bfa24112030340e2400727e/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
[modify] https://crrev.com/755650c7085bb4c07bfa24112030340e2400727e/android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewThreadTest.java

Comment 5 by boliu@chromium.org, Jul 29 2016

Status: Fixed (was: Untriaged)

Comment 6 by sgu...@chromium.org, Jul 29 2016 

Another successful hit from CTS bot :) Thanks Yoland!
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 29 2016 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/52c894ae9f35755a0a3fc682bcb4a852e436d3f3

commit 52c894ae9f35755a0a3fc682bcb4a852e436d3f3
Author: boliu <boliu@chromium.org>
Date: Fri Jul 29 02:12:47 2016

Comment 8 by boliu@chromium.org, Jul 29 2016 

 Issue 632830  has been merged into this issue.
►

Sign in to add a comment