Context Menu does not work for TH/ID/MY experiment |
|||
Issue descriptionVersion: M52 or later OS: ALL The current code in chrome/browser/renderer_context_menu/render_view_context_menu.cc always use the Application Locale for the context menu "Translate To ... " language. This should be switch to using the TranslateManager::GetTargetLanguage()" instead so it will also reflect in the TH/ID/MY experiment. I found this bug by looking at the code. I do not know how to reproduce this since it require the user be in Thailand/Malaysia or Indonesia as well as in the experiment to see the issue. groby - how can we in black box test to fool the chrome to think we are in Thailand? We should switch the code to use TranslateManager::GetTargetLanguage(). This is also needed for the ULP integration.
,
Jul 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9939a671897e4500ecb8fa83ec43ca497a8ab161 commit 9939a671897e4500ecb8fa83ec43ca497a8ab161 Author: ftang <ftang@chromium.org> Date: Fri Jul 29 06:02:32 2016 Use TranslateManager::GetTargetLanguage() for context menu BUG= 632545 Review-Url: https://codereview.chromium.org/2189283002 Cr-Commit-Position: refs/heads/master@{#408587} [modify] https://crrev.com/9939a671897e4500ecb8fa83ec43ca497a8ab161/chrome/browser/renderer_context_menu/render_view_context_menu.cc
,
Jul 29 2016
groby- how can I fake myself to be in Thailand to verify this fix?
,
Aug 5 2016
chrome://translate-internals/ See "Override variations country"
,
Aug 11 2016
,
Apr 27 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ftang@chromium.org
, Jul 29 2016