New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632543 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Dropdown menus without a label are not centering correctly

Project Member Reported by dschuyler@chromium.org, Jul 29 2016

Issue description

Dropdown menus without a label, but without
the no-label-float property, still reserve space
for the label. This causes the item to appear 
incorrectly vertically aligned.
 
Screenshot from 2016-07-28 18:21:01.png
4.9 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f17545cbfb8920106632a5e7d35ae57c0df4296

commit 8f17545cbfb8920106632a5e7d35ae57c0df4296
Author: dschuyler <dschuyler@chromium.org>
Date: Fri Jul 29 18:33:30 2016

[MD settings] remove label float from dropdowns so that they center correctly

This CL adds the no-label-float property to dropdowns without a label so
that they center correctly vertically.

BUG= 632543 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2191203002
Cr-Commit-Position: refs/heads/master@{#408696}

[modify] https://crrev.com/8f17545cbfb8920106632a5e7d35ae57c0df4296/chrome/browser/resources/settings/search_page/search_page.html
[modify] https://crrev.com/8f17545cbfb8920106632a5e7d35ae57c0df4296/chrome/browser/resources/settings/site_settings/media_picker.html
[modify] https://crrev.com/8f17545cbfb8920106632a5e7d35ae57c0df4296/chrome/browser/resources/settings/site_settings/site_data_details_dialog.html

Status: Fixed (was: Started)

Sign in to add a comment