New issue
Advanced search Search tips

Issue 632529 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

DevTools: screenshot popovers in animations drawer sometimes don't load

Project Member Reported by l...@chromium.org, Jul 29 2016

Issue description

Version: 54.0.2810.0
OS: Linux

What steps will reproduce the problem?
(1) Open the 'Animation' drawer panel in DevTools
(2) Generate some animations (e.g. going to 'https://www.google.com/#q=foo' and clicking on the 9-square icon in the top right
(3) Mouseover the animation minishots in the drawer and wait for the popup to appear

What is the expected output?
The screenshot popup should appear.

What do you see instead?
Just the little arrow shows up, no screenshot.  If you mouseout and mouseover again, screenshot now appears.


Suspecting commit:
https://chromium.googlesource.com/chromium/src/+/d0c9ac3bf5bb4843c2c189a72e7b6c39e6743831
 

Comment 1 by l...@chromium.org, Jul 29 2016

badanimationpopover.png
56.2 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b90447cdf5dcc6ea76146ebf3b63881cd7a3e0f

commit 3b90447cdf5dcc6ea76146ebf3b63881cd7a3e0f
Author: luoe <luoe@chromium.org>
Date: Tue Aug 02 21:33:32 2016

DevTools: fix animations panel after image loading became async

The loading of data URIs is now async, which affected the visibility of
animation screenshot popovers. Popover measurement is taken right after being
shown, so this CL waits for images to load before taking the measurement.

See https://codereview.chromium.org/2173003002

BUG= 632529 

Review-Url: https://codereview.chromium.org/2199103002
Cr-Commit-Position: refs/heads/master@{#409330}

[modify] https://crrev.com/3b90447cdf5dcc6ea76146ebf3b63881cd7a3e0f/third_party/WebKit/Source/devtools/front_end/animation/AnimationTimeline.js

Comment 3 by l...@chromium.org, Aug 8 2016

Status: Fixed (was: Started)

Sign in to add a comment