New issue
Advanced search Search tips

Issue 632516 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Milo: Console view prototype

Project Member Reported by hinoka@chromium.org, Jul 28 2016

Issue description

Console view like build.chromium.org
 

Comment 1 by hinoka@chromium.org, Jul 29 2016

Labels: -W-0808 W-0801
Summary: Milo: Console view prototype (was: Milo: Console view)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7

commit 19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7
Author: hinoka <hinoka@google.com>
Date: Fri Aug 05 00:15:11 2016

Milo: Console view prototype

This is pretty hacked up.  Namely:
* This does a 25 build query for _each_ builder, and then filter out the correct revision
* This loads the entire build (including un-gzip and json deserialization) just to take like 5 pieces of information from it (~1000ms for the whole process)
* Hits gitiles for every query (70ms)
* Only buildbot is supported
* Config is hard-coded instead of being loaded from luci-cfg

All of the issues above will be addressed later, this is mostly to get a demo out.

BUG= 632516 

Review-Url: https://codereview.chromium.org/2196453002

[modify] https://crrev.com/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7/appengine/cmd/milo/Makefile
[modify] https://crrev.com/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7/appengine/cmd/milo/buildbot/builder.go
[add] https://crrev.com/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7/appengine/cmd/milo/buildbot/console.go
[modify] https://crrev.com/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7/appengine/cmd/milo/buildbucket/builder_test.go
[rename] https://crrev.com/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7/appengine/cmd/milo/buildbucket/expectations/master.tryserver.infra/InfraPresubmit.Swarming.json
[rename] https://crrev.com/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7/appengine/cmd/milo/buildbucket/testdata/master.tryserver.infra/InfraPresubmit.Swarming.json
[add] https://crrev.com/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7/appengine/cmd/milo/console/console.go
[add] https://crrev.com/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7/appengine/cmd/milo/console/html.go
[add] https://crrev.com/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7/appengine/cmd/milo/console/html_data.go
[modify] https://crrev.com/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7/appengine/cmd/milo/frontend/app.yaml
[modify] https://crrev.com/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7/appengine/cmd/milo/frontend/milo.go
[modify] https://crrev.com/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7/appengine/cmd/milo/frontend/static/buildbot/css/default.css
[add] https://crrev.com/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7/appengine/cmd/milo/frontend/templates/buildbot/pages/console.html
[add] https://crrev.com/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7/appengine/cmd/milo/git/gitiles.go
[add] https://crrev.com/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7/appengine/cmd/milo/resp/console.go
[modify] https://crrev.com/19b5ff60eca7ed2c7a3f2b71cd1b6ab99d3e04b7/appengine/cmd/milo/settings/funcs.go

Comment 3 by hinoka@chromium.org, Aug 12 2016

Labels: -W-0801 W-0815

Comment 4 by hinoka@chromium.org, Aug 12 2016

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/16d9cb920d627eae77d9b22e4ed951a5e3effce1

commit 16d9cb920d627eae77d9b22e4ed951a5e3effce1
Author: hinoka <hinoka@google.com>
Date: Fri Aug 19 00:01:23 2016

Milo: Use luci-cfg for defining projects and console view.

* Console urls now /console/<project>/<name>
** If the name is missing, it will be "default"

BUG= 632516 

Review-Url: https://codereview.chromium.org/2238883003

[modify] https://crrev.com/16d9cb920d627eae77d9b22e4ed951a5e3effce1/milo/appengine/console/console.go
[modify] https://crrev.com/16d9cb920d627eae77d9b22e4ed951a5e3effce1/milo/appengine/console/html.go
[modify] https://crrev.com/16d9cb920d627eae77d9b22e4ed951a5e3effce1/milo/appengine/frontend/app.yaml
[modify] https://crrev.com/16d9cb920d627eae77d9b22e4ed951a5e3effce1/milo/appengine/frontend/cron.yaml
[modify] https://crrev.com/16d9cb920d627eae77d9b22e4ed951a5e3effce1/milo/appengine/frontend/milo.go
[add] https://crrev.com/16d9cb920d627eae77d9b22e4ed951a5e3effce1/milo/appengine/settings/config.go
[add] https://crrev.com/16d9cb920d627eae77d9b22e4ed951a5e3effce1/milo/appengine/settings/config_test.go
[add] https://crrev.com/16d9cb920d627eae77d9b22e4ed951a5e3effce1/milo/common/config/generate.go
[add] https://crrev.com/16d9cb920d627eae77d9b22e4ed951a5e3effce1/milo/common/config/project.pb.go
[add] https://crrev.com/16d9cb920d627eae77d9b22e4ed951a5e3effce1/milo/common/config/project.proto

Sign in to add a comment