accelerometer: Do not assume trigger0 the trigger to use. |
|||||||||||||||||||||
Issue descriptionWhen we add cros-ec-ring (needed for ARC++), we add another trigger. It happens that this new trigger is named trigger0, and the sysfs trigger becomes trigger1. We have to look at the trigger name and find the one that starts with "sysfstrig". Then we can use that trigger <devices/triggerX/trigger_now>
,
Jul 28 2016
,
Aug 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1ade62df9003dc43cc47037d8207a2a6b89c3014 commit 1ade62df9003dc43cc47037d8207a2a6b89c3014 Author: gwendal <gwendal@google.com> Date: Mon Aug 08 20:01:03 2016 Accelerometer: find trigger name Do not assume the sysfs trigger to use is trigger0. Instead find the trigger which name is "sysfstrig0". This is the name used by accelerometer-init.sh udev script. BUG= chromium:632486 TEST=With proper accelerometer-init.sh, check that chrome rotate screen even when cros-ec-ring driver is loaded. R=jonross@chromium.org Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Review-Url: https://codereview.chromium.org/2198543002 Cr-Commit-Position: refs/heads/master@{#410407} [modify] https://crrev.com/1ade62df9003dc43cc47037d8207a2a6b89c3014/chromeos/accelerometer/accelerometer_reader.cc
,
Aug 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/e9d2bb6b9806066f7db4625469ed8730eab265a0 commit e9d2bb6b9806066f7db4625469ed8730eab265a0 Author: Gwendal Grignou <gwendal@chromium.org> Date: Fri Jul 29 16:41:10 2016 cromeos-accelerometer-init: Set trigger properly Do not assume sysfs trigger is trigger0. However, use the trigger name as built by the kernel to setup the sensors trigger. BUG= chromium:632486 TEST=Check the sensor trigger name is correct even when trigger0 is not sysfs trigger. cat iio\:device1/trigger/current_trigger returns sysfstrig0. TEST=Check that chrome can access the sensor. Change-Id: Id4f2df2d5145d33cb4e345e9688cb0f0482ad937 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/364692 [rename] https://crrev.com/e9d2bb6b9806066f7db4625469ed8730eab265a0/chromeos-base/chromeos-accelerometer-init/chromeos-accelerometer-init-0.0.1-r10.ebuild [modify] https://crrev.com/e9d2bb6b9806066f7db4625469ed8730eab265a0/chromeos-base/chromeos-accelerometer-init/files/udev/accelerometer-init.sh
,
Aug 20 2016
,
Aug 24 2016
Theses changes are needed for M52, where we want to chip a newer Cyan firmware.
,
Aug 24 2016
,
Aug 24 2016
[Automated comment] Request affecting a post-stable build (M52), manual review required.
,
Aug 24 2016
,
Aug 24 2016
[Automated comment] Less than 2 weeks to go before stable on M53, manual review required.
,
Aug 25 2016
,
Aug 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3a1b5e416d56655b2016a122f02f8150c8075407 commit 3a1b5e416d56655b2016a122f02f8150c8075407 Author: Gwendal Grignou <gwendal@chromium.org> Date: Fri Jul 29 16:41:10 2016 cromeos-accelerometer-init: Set trigger properly Do not assume sysfs trigger is trigger0. However, use the trigger name as built by the kernel to setup the sensors trigger. BUG= chromium:632486 TEST=Check the sensor trigger name is correct even when trigger0 is not sysfs trigger. cat iio\:device1/trigger/current_trigger returns sysfstrig0. TEST=Check that chrome can access the sensor. Change-Id: Id4f2df2d5145d33cb4e345e9688cb0f0482ad937 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/364692 (cherry picked from commit e9d2bb6b9806066f7db4625469ed8730eab265a0) Reviewed-on: https://chromium-review.googlesource.com/375718 [rename] https://crrev.com/3a1b5e416d56655b2016a122f02f8150c8075407/chromeos-base/chromeos-accelerometer-init/chromeos-accelerometer-init-0.0.1-r10.ebuild [modify] https://crrev.com/3a1b5e416d56655b2016a122f02f8150c8075407/chromeos-base/chromeos-accelerometer-init/files/udev/accelerometer-init.sh
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bb2a8af09e6554893ed8e6844f82f004b2a215da commit bb2a8af09e6554893ed8e6844f82f004b2a215da Author: Gwendal Grignou <gwendal@chromium.org> Date: Fri Jul 29 16:41:10 2016 cromeos-accelerometer-init: Set trigger properly Do not assume sysfs trigger is trigger0. However, use the trigger name as built by the kernel to setup the sensors trigger. BUG= chromium:632486 TEST=Check the sensor trigger name is correct even when trigger0 is not sysfs trigger. cat iio\:device1/trigger/current_trigger returns sysfstrig0. TEST=Check that chrome can access the sensor. Change-Id: Id4f2df2d5145d33cb4e345e9688cb0f0482ad937 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/364692 (cherry picked from commit e9d2bb6b9806066f7db4625469ed8730eab265a0) Reviewed-on: https://chromium-review.googlesource.com/375718 (cherry picked from commit 3a1b5e416d56655b2016a122f02f8150c8075407) Reviewed-on: https://chromium-review.googlesource.com/376900 [rename] https://crrev.com/bb2a8af09e6554893ed8e6844f82f004b2a215da/chromeos-base/chromeos-accelerometer-init/chromeos-accelerometer-init-0.0.1-r10.ebuild [modify] https://crrev.com/bb2a8af09e6554893ed8e6844f82f004b2a215da/chromeos-base/chromeos-accelerometer-init/files/udev/accelerometer-init.sh
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/edffa8cf393d8ba7930a06dc93b3b252560c5b22 commit edffa8cf393d8ba7930a06dc93b3b252560c5b22 Author: gwendal <gwendal@chromium.org> Date: Fri Aug 26 23:55:01 2016 Accelerometer: find trigger name Do not assume the sysfs trigger to use is trigger0. Instead find the trigger which name is "sysfstrig0". This is the name used by accelerometer-init.sh udev script. BUG= chromium:632486 TEST=With proper accelerometer-init.sh, check that chrome rotate screen even when cros-ec-ring driver is loaded. NOTRY=true NOPRESUBMIT=true R=jonross@chromium.org Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Review-Url: https://codereview.chromium.org/2198543002 Cr-Commit-Position: refs/heads/master@{#410407} (cherry picked from commit 1ade62df9003dc43cc47037d8207a2a6b89c3014) Review-Url: https://codereview.chromium.org/2277133002 Cr-Commit-Position: refs/branch-heads/2785@{#770} Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382} [modify] https://crrev.com/edffa8cf393d8ba7930a06dc93b3b252560c5b22/chromeos/accelerometer/accelerometer_reader.cc
,
Aug 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fb78252109af48b3001a998a3120de99fd1d9a9 commit 6fb78252109af48b3001a998a3120de99fd1d9a9 Author: gwendal <gwendal@chromium.org> Date: Sat Aug 27 10:36:09 2016 Accelerometer: find trigger name Do not assume the sysfs trigger to use is trigger0. Instead find the trigger which name is "sysfstrig0". This is the name used by accelerometer-init.sh udev script. BUG= chromium:632486 TEST=With proper accelerometer-init.sh, check that chrome rotate screen even when cros-ec-ring driver is loaded. NOTRY=true NOPRESUBMIT=true TBR=oshima@chromium.org R=jonross@chromium.org Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Review-Url: https://codereview.chromium.org/2198543002 Cr-Commit-Position: refs/heads/master@{#410407} (cherry picked from commit 1ade62df9003dc43cc47037d8207a2a6b89c3014) Review-Url: https://codereview.chromium.org/2284093002 Cr-Commit-Position: refs/branch-heads/2743@{#737} Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939} [modify] https://crrev.com/6fb78252109af48b3001a998a3120de99fd1d9a9/chromeos/accelerometer/accelerometer_reader.cc
,
Oct 7 2016
,
Nov 19 2016
,
Jan 21 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by gwendal@chromium.org
, Jul 28 2016