[Bulk edit]

This issue is listed as a release block stable for M54 Android.  We'll be cutting our stable candidate in just about two weeks, so time is running out to fix this bug - please prioritize working on it ASAP.

Are you sure this issue shouldn't block the release?  Remove the ReleaseBlock-Stable label.
Unsure if this issue should block the release, or know the issue should block the release but we won't be able to fix it in time?  CC me so that we can discuss.

Thanks!

Device: Nexus 9 Tablet /NRD91N
Not able to repro on chrome Dev '55.0.2880.0'
Not able to rero on chrome Beta '54.0.2842.42'

will file new/reopen this if discovered in our testing.

Will file new/reopen this if discovered in testing.

New repro steps.  On a Tablet:
1) Tap on a word to search, expand the panel, promote to separate Tab.
2) Close the Tab and tap on the same word, expand the panel

Observe: overflows width (as in previous screenshot).
Expected: narrow panel.

ramine@ can you try to repro with the steps in #5?

ramine@ can you try to repro with the steps in #5?

We now have a good repro and know what's going on:

1) Scroll controls off
2) tap to open CS and promote to a tab
3) go back to the original tab and tap again on the search (controls will have reappeared)
4) Open the panel quickly while top controls are still in view.

When you promote to a tab the top controls show.  Then with the new tap creating the overlay the top controls animate off while the panel is being opened and that causes an update to the width that is wrong.

Ted is changing the top controls logic, which will fix this.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f933d51ebdb5027f27e79a9a816857bbdee12ba

commit 3f933d51ebdb5027f27e79a9a816857bbdee12ba
Author: donnd <donnd@chromium.org>
Date: Thu Nov 10 20:51:45 2016

[TTS][Overlay] Fix content width overflowing narrow panel.

When the top controls are shown by the Browser, the Overlay Panel gets
many onSizeChanged events while the controls animate off the top. This
can cause the panel content to overflow a narrow panel on tablet.

The panel now ignores the onSizeChanged calls if they have the same
height as previous calls.

BUG= 632483 

Review-Url: https://codereview.chromium.org/2486003004
Cr-Commit-Position: refs/heads/master@{#431345}

[modify] https://crrev.com/3f933d51ebdb5027f27e79a9a816857bbdee12ba/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

Requesting merge of change in #10 to M55.

Your change meets the bar and is auto-approved for M55 (branch: 2883)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea64b4bb0f8733eca15c998be8b7634c87f32728

commit ea64b4bb0f8733eca15c998be8b7634c87f32728
Author: donnd <donnd@chromium.org>
Date: Wed Nov 16 06:41:54 2016

[TTS][Overlay] Update fix to overflowing the narrow panel.

A previous fix just checked if the height changed, but looks like
there's a split-window case that needs to check if the width changes.
Now checking if either changes.

BUG= 632483 

Review-Url: https://codereview.chromium.org/2504703002
Cr-Commit-Position: refs/heads/master@{#432405}

[modify] https://crrev.com/ea64b4bb0f8733eca15c998be8b7634c87f32728/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9892b4fa654f59a436144637f5b71c643d0b2f6a

commit 9892b4fa654f59a436144637f5b71c643d0b2f6a
Author: Donn Denman <donnd@google.com>
Date: Sat Nov 19 01:19:54 2016

[TTS][Overlay] Fix content width overflowing narrow panel.

When the top controls are shown by the Browser, the Overlay Panel gets
many onSizeChanged events while the controls animate off the top. This
can cause the panel content to overflow a narrow panel on tablet.

The panel now ignores the onSizeChanged calls if they have the same
height as previous calls.

BUG= 632483 

Review-Url: https://codereview.chromium.org/2486003004
Cr-Commit-Position: refs/heads/master@{#431345}
(cherry picked from commit 3f933d51ebdb5027f27e79a9a816857bbdee12ba)

Review URL: https://codereview.chromium.org/2514143002 .

Cr-Commit-Position: refs/branch-heads/2883@{#618}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/9892b4fa654f59a436144637f5b71c643d0b2f6a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

I need an additional merge to fix this.  #10 has been merged but #13 is needed too.  It's a simple update to the fix in #10.

Your change meets the bar and is auto-approved for M55 (branch: 2883)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c589e40897eaf1fd83b38a93e867d51fb4ad05f

commit 3c589e40897eaf1fd83b38a93e867d51fb4ad05f
Author: Donn Denman <donnd@google.com>
Date: Sat Nov 19 01:55:33 2016

[TTS][Overlay] Update fix to overflowing the narrow panel.

A previous fix just checked if the height changed, but looks like
there's a split-window case that needs to check if the width changes.
Now checking if either changes.

BUG= 632483 

Review-Url: https://codereview.chromium.org/2504703002
Cr-Commit-Position: refs/heads/master@{#432405}
(cherry picked from commit ea64b4bb0f8733eca15c998be8b7634c87f32728)

Review URL: https://codereview.chromium.org/2506373006 .

Cr-Commit-Position: refs/branch-heads/2883@{#620}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/3c589e40897eaf1fd83b38a93e867d51fb4ad05f/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java