New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 632455 link

Starred by 1 user
Status: Verified
Owner:
xiy...@chromium.org
Closed: Aug 2016
Cc:
█ keta...@chromium.org
█ reve...@chromium.org
█ yoshiki@chromium.org
█ zelidrag@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ARC custom notification needs to handle size chage

Project Member Reported by xiy...@chromium.org, Jul 28 2016 
To repro, use an app that creates size changing notification, e.g. Orbot, and observe the notification.

When the notification grows, it appear clipped. When it shrinks, white space is revealed.

This is because notification size change is ignored ATM. 

reveman@, you were right that we need to handle this. :p

Comment 2 by xiy...@chromium.org, Aug 2 2016

Labels: -M-54 Merge-Request-53 M-53

Comment 3 by dimu@chromium.org, Aug 2 2016

Labels: -Merge-Request-53 Merge-Review-53 Hotlist-Merge-Review
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.

Comment 4 by xiy...@chromium.org, Aug 3 2016

Cc: keta...@chromium.org
ketakid@, could you approve the merge for M53? Thanks.
Project Member

Comment 5 by sheriffbot@chromium.org, Aug 5 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by xiy...@chromium.org, Aug 5 2016

Labels: -M-54 -MovedFrom-53 M-53
Move back to M53.

TPMs, ping on the merge request?

Comment 7 by keta...@chromium.org, Aug 5 2016

Labels: -Merge-Review-53 Merge-Approved-53
Approving merge to M53 cros.
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 5 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0928d552b6ac0d540e79d6f54faa1052ad375aea

commit 0928d552b6ac0d540e79d6f54faa1052ad375aea
Author: Xiyuan Xia <xiyuan@google.com>
Date: Fri Aug 05 20:38:42 2016

Merge "arc: Support custom notification size change"

> BUG= 632455 
> BUG=b/30477159
> TEST=Manual. Run Orbot and observe the notification change its size.
>
> Review-Url: https://codereview.chromium.org/2192023002
> Cr-Commit-Position: refs/heads/master@{#408987}
> (cherry picked from commit cb1c37150e121db2219060eaede70389dc11edea)

Review URL: https://codereview.chromium.org/2223583002 .

Cr-Commit-Position: refs/branch-heads/2785@{#515}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/0928d552b6ac0d540e79d6f54faa1052ad375aea/ui/arc/BUILD.gn
[modify] https://crrev.com/0928d552b6ac0d540e79d6f54faa1052ad375aea/ui/arc/arc.gyp
[modify] https://crrev.com/0928d552b6ac0d540e79d6f54faa1052ad375aea/ui/arc/notification/DEPS
[modify] https://crrev.com/0928d552b6ac0d540e79d6f54faa1052ad375aea/ui/arc/notification/arc_custom_notification_view.cc
[modify] https://crrev.com/0928d552b6ac0d540e79d6f54faa1052ad375aea/ui/arc/notification/arc_custom_notification_view.h
[modify] https://crrev.com/0928d552b6ac0d540e79d6f54faa1052ad375aea/ui/message_center/views/message_center_view.cc

Comment 9 by xiy...@chromium.org, Aug 5 2016

Status: Fixed (was: Assigned)

Comment 10 by rookrishna@chromium.org, Sep 27 2016

Status: Verified (was: Fixed)
►

Sign in to add a comment