Issue metadata
Sign in to add a comment
|
Chrome repeats a letter in the accessible name calculation whenever a first-letter style is applied
Reported by
bbri...@microsoft.com,
Jul 28 2016
|
||||||||||||||||||||||||
Issue descriptionWhat steps will reproduce the problem? (1) https://jsfiddle.net/boggydigital/9fuLg3s5/ What is the expected output? Computed accessible name for header element is "The accessible name..." What do you see instead? "TThe accessible name..." Doesn't repro in Edge, Firefox. Both expose "T" letter as anonymous text element under the header as expected.
,
Aug 12 2016
,
Oct 3 2016
Bulk-adding Hotlist-Interop to bugs filed by other browser vendors based on the summary. Feel free to remove if this issue doesn't actually reflect a difference in behavior between engines.
,
Oct 21 2016
Issue 538116 has been merged into this issue.
,
Oct 24 2016
Dominic, Alice - could one of you take a look for triage?
,
Nov 14 2016
Dominic, Alice, could you please help triage this Hotlist-Interop issue?
,
Nov 23 2016
Looked into this, and it looks like we need to do some special tree traversal to walk the FirstLetterPseudoElement layout object correctly. +eae for more thoughts.
,
Nov 24 2016
,
Nov 24 2016
I can take a look. Thank you Bogdan for the WebKit change.
,
Nov 24 2016
kojii@ - feel free to ping me to chat about a11y tree code if you like!
,
Nov 25 2016
Thank you aboxhall@, WIP here https://codereview.chromium.org/2524313002/
,
Nov 28 2016
,
Nov 28 2016
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de49a2b1783ddecd7c1785287f76a4bbe468fdc2 commit de49a2b1783ddecd7c1785287f76a4bbe468fdc2 Author: kojii <kojii@chromium.org> Date: Mon Nov 28 14:56:39 2016 Fix AXLayoutObject not to add duplicated children for CSS first-letter This patch fixes AXLayoutObject not to add first-letter pseudo elements twice in the accessibility tree. Similar fix to the one in WebKit[1], but the condition was changed only for first-letter pseudo element because of the difference in the layout tree structure. [1] https://trac.webkit.org/changeset/203694/ BUG= 632453 Review-Url: https://codereview.chromium.org/2524313002 Cr-Commit-Position: refs/heads/master@{#434657} [add] https://crrev.com/de49a2b1783ddecd7c1785287f76a4bbe468fdc2/third_party/WebKit/LayoutTests/accessibility/css-first-letter-children.html [modify] https://crrev.com/de49a2b1783ddecd7c1785287f76a4bbe468fdc2/third_party/WebKit/LayoutTests/accessibility/first-letter-text-transform-causes-crash-expected.txt [modify] https://crrev.com/de49a2b1783ddecd7c1785287f76a4bbe468fdc2/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
,
Nov 28 2016
,
Dec 5 2016
Verified the fix on Version 57.0.2939.1 canary SyzyASan Thank you Koji and Alice! |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bbri...@microsoft.com
, Aug 4 2016