New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 632451 link

Starred by 2 users
Status: Fixed
Owner:
donnd@chromium.org
Closed: Oct 2016
Cc:
█ zkoch@chromium.org
twelling...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature



Sign in to add a comment

[TTS] Switch Finch usage from params to features

Project Member Reported by donnd@chromium.org, Jul 28 2016 
We use finch params to control specific features in Contextual Search, but now there's a better mechanism that can be used: enable_features.  The Features support command-line flags and also chrome://flags.  More at https://g3doc.corp.google.com/analysis/uma/g3doc/finch/feature-api.md?cl=head

From Java we can just use ChromeFeatureList.isEnabled(FEATURE_NAME).  We should do this for the next feature for CS, so targeting M54.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/43d1cea49ccf69b219373cfa9e8d105bb3c25f4e

commit 43d1cea49ccf69b219373cfa9e8d105bb3c25f4e
Author: donnd <donnd@chromium.org>
Date: Wed Oct 26 18:51:53 2016

[TTS] Add a Feature and about:flag for Single Actions.

Adds a Field Trial Feature to enable single actions using Contextual Cards.
Exposes the feature in about:flags.
This feature doesn't do anything yet.

BUG=657063, 632451 

Review-Url: https://codereview.chromium.org/2429033002
Cr-Commit-Position: refs/heads/master@{#427764}

[modify] https://crrev.com/43d1cea49ccf69b219373cfa9e8d105bb3c25f4e/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/43d1cea49ccf69b219373cfa9e8d105bb3c25f4e/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
[modify] https://crrev.com/43d1cea49ccf69b219373cfa9e8d105bb3c25f4e/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
[modify] https://crrev.com/43d1cea49ccf69b219373cfa9e8d105bb3c25f4e/chrome/app/generated_resources.grd
[modify] https://crrev.com/43d1cea49ccf69b219373cfa9e8d105bb3c25f4e/chrome/browser/about_flags.cc
[modify] https://crrev.com/43d1cea49ccf69b219373cfa9e8d105bb3c25f4e/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/43d1cea49ccf69b219373cfa9e8d105bb3c25f4e/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/43d1cea49ccf69b219373cfa9e8d105bb3c25f4e/tools/metrics/histograms/histograms.xml

Comment 2 by donnd@chromium.org, Oct 26 2016

Status: Fixed (was: Assigned)
I think we should use Features for new items, but leave the old controls as params.

The above CL shows an example of using Finch Features.
►

Sign in to add a comment