Gerrit CQ: avoid races with user when deleting CQ label vote |
|||||||
Issue descriptionIssue 618784 implements CQ removing votes triggering CQ when attempt passed or failed. There is potential race between USER and CQ changing vote at the same time. Most likely it'd be this: 1. User: label-Commit-Queue => 1 (Dry Run) 2. CQ starts and runs dry run, tryjobs are green. 3. User notices green tryjobs decides to trigger full CQ run. CQ also notices tryjobs, decides to stop dry run with a success. 4. CQ: label-Commit-Queue => 0 (on behalf of User) USER: label-Commit-Queue => 2 It'd be great to remove negative effect from this if CQ could somehow tell Gerrit to delete vote IF AND ONLY IF nothing changed since CQ read Gerrit data.
,
Sep 27 2016
,
Sep 27 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 27 2017
Nobody complained on my watch about this, so Pri3.
,
Jan 3 2018
Removing Milestone-Afterglow, as it has ceased to have meaning. More refined milestones may be added back in the near future.
,
Jan 4
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 4
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tandrii@chromium.org
, Jul 28 2016