New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632443 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression

Blocking:
issue 614588



Sign in to add a comment

“Automatically send usage statistics and crash reports to Google” checkbox missing from Material Design settings page

Project Member Reported by mark@chromium.org, Jul 28 2016

Issue description

The “Automatically send usage statistics and crash reports to Google” checkbox is missing from Material Design settings page (about:settings with about:flags#enable-md-settings enabled).

At https://chromium.googlesource.com/chromium/src/+/369fb42299c568256ce9c8821967b9c413ea4151/chrome/browser/resources/settings/privacy_page/privacy_page.html#61, I found:

 72            <!-- TODO(jlklein): Add non-chromeos metrics box. -->
 
Status: Assigned (was: Untriaged)
Untriaged + Owner -> Assigned

Labels: -Pri-3 Pri-1
Sounds like a P1, not a P3.

Comment 3 by mark@chromium.org, Jul 28 2016

Wasn’t sure if MD Settings is targeted at a particular release, so I couldn’t set an M-label either. D’ya know?
Owner: dbeam@chromium.org

Comment 5 by dbeam@chromium.org, Jul 29 2016

Labels: -Type-Bug -OS-All OS-Chrome OS-Linux OS-Mac OS-Windows Type-Bug-Regression
no surefire milestone yet

Comment 6 by dbeam@chromium.org, Jul 29 2016

Cc: tbuck...@chromium.org
Blocking: 614588
Labels: Hotlist-MD-Settings-Privacy

Comment 8 by dbeam@chromium.org, Aug 6 2016

Labels: -OS-Chrome
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a620af406275d8e5bf37832661f773ec60f3802a

commit a620af406275d8e5bf37832661f773ec60f3802a
Author: dbeam <dbeam@chromium.org>
Date: Thu Aug 11 06:09:20 2016

MD Settings: implement metrics reporting checkbox on desktop

BUG= 614265 , 632443 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2233443002
Cr-Commit-Position: refs/heads/master@{#411276}

[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/metrics/chrome_metrics_service_accessor.h
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/resources/settings/privacy_page/compiled_resources2.gyp
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/resources/settings/privacy_page/privacy_page.js
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/resources/settings/privacy_page/privacy_page_browser_proxy.js
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/ui/webui/settings/md_settings_ui.cc
[add] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/ui/webui/settings/metrics_reporting_handler.cc
[add] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/ui/webui/settings/metrics_reporting_handler.h
[add] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/test/data/webui/settings/cr_settings_browsertest.js
[add] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/chrome/test/data/webui/settings/metrics_reporting_tests.js
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/ui/webui/resources/cr_elements/policy/cr_policy_indicator.css
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js
[add] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/ui/webui/resources/cr_elements/policy/cr_policy_vars_css.html
[modify] https://crrev.com/a620af406275d8e5bf37832661f773ec60f3802a/ui/webui/resources/cr_elements_resources.grdp

Comment 10 by dbeam@chromium.org, Aug 11 2016

Status: Fixed (was: Started)

Sign in to add a comment