New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632432 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

MD Settigs: Exception thrown when visiting "Manage passwords" subpage.

Project Member Reported by dpa...@chromium.org, Jul 28 2016

Issue description

Seems to be caused by https://codereview.chromium.org/2180843006. The error is

polymer-mini-extracted.js:2034 Uncaught TypeError: Cannot set property 'bindValue' of undefined

and it is thrown from https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js?q=cr_search_field_behavior.js&l=58.
 

Comment 1 by dpa...@chromium.org, Jul 28 2016

Repro steps:
1) Load MD Settings
2) Initiate a search (for example 'foo')
3) Initiate a 2nd search after you see the spinner.

Comment 2 by dpa...@chromium.org, Jul 28 2016

I think https://codereview.chromium.org/2188063003 is fixing the issue. My understanding is that after CL 2180843006, every element implementing the CrSearchFieldBehavior must override the getSearchInput() method. Unfortunately the compiler does not seem to detect cases where the @abstract method is not overriden.

Comment 3 by dpa...@chromium.org, Jul 28 2016

Also it turns out the compiler does not like marking such methods with @override (see following error)

(ERROR) Error in: settings_subpage_search.js
## /usr/local/google/home/dpapad/workspace/chromium1/src/chrome/browser/resources/settings/settings_page/settings_subpage_search.js:18: ERROR - property getSearchInput not defined on any superclass of SettingsSubpageSearchElement
##   getSearchInput: function() {
##                   ^

It seems that the compiler's PolymerPass does not understand @abstract inside behaviors and @override inside a behavior's implementor.

Comment 4 by dpa...@chromium.org, Jul 28 2016

To clarify a bit, this error can be reproduced without searching. It actually happens when the "manage passwords" subpage is rendered. It just happens that searching force-renders the "manage passwords" subpage, and also triggers the error.

Alternative repro steps
1) Navigate to chrome://md-settings/managePasswords
2) Observe error in the console.

Comment 5 by dpa...@chromium.org, Jul 28 2016

Summary: MD Settigs: Exception thrown when visiting "Manage passwords" subpage. (was: MD Settigs: Exception thrown while searching)

Comment 6 by dpa...@chromium.org, Jul 28 2016

Owner: dpa...@chromium.org
Status: Started (was: Untriaged)
Fix is in the CQ, https://codereview.chromium.org/2188063003.

Comment 7 by dpa...@chromium.org, Jul 28 2016

Cc: tsergeant@chromium.org
Argh, I didn't realise this one existed. It's frustrating that Closure didn't help us find this before the change landed.
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36579b0bc9520e57ed45539d3f82d668d9c2dc2b

commit 36579b0bc9520e57ed45539d3f82d668d9c2dc2b
Author: dpapad <dpapad@chromium.org>
Date: Thu Jul 28 23:55:32 2016

MD Settings: Fix runtime error when visiting "manage passwords" page.

BUG= 632432 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2188063003
Cr-Commit-Position: refs/heads/master@{#408513}

[modify] https://crrev.com/36579b0bc9520e57ed45539d3f82d668d9c2dc2b/chrome/browser/resources/settings/settings_page/settings_subpage_search.js

Status: Fixed (was: Started)

Sign in to add a comment