MD Settigs: Exception thrown when visiting "Manage passwords" subpage. |
|||||
Issue descriptionSeems to be caused by https://codereview.chromium.org/2180843006. The error is polymer-mini-extracted.js:2034 Uncaught TypeError: Cannot set property 'bindValue' of undefined and it is thrown from https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_search_field/cr_search_field_behavior.js?q=cr_search_field_behavior.js&l=58.
,
Jul 28 2016
I think https://codereview.chromium.org/2188063003 is fixing the issue. My understanding is that after CL 2180843006, every element implementing the CrSearchFieldBehavior must override the getSearchInput() method. Unfortunately the compiler does not seem to detect cases where the @abstract method is not overriden.
,
Jul 28 2016
Also it turns out the compiler does not like marking such methods with @override (see following error)
(ERROR) Error in: settings_subpage_search.js
## /usr/local/google/home/dpapad/workspace/chromium1/src/chrome/browser/resources/settings/settings_page/settings_subpage_search.js:18: ERROR - property getSearchInput not defined on any superclass of SettingsSubpageSearchElement
## getSearchInput: function() {
## ^
It seems that the compiler's PolymerPass does not understand @abstract inside behaviors and @override inside a behavior's implementor.
,
Jul 28 2016
To clarify a bit, this error can be reproduced without searching. It actually happens when the "manage passwords" subpage is rendered. It just happens that searching force-renders the "manage passwords" subpage, and also triggers the error. Alternative repro steps 1) Navigate to chrome://md-settings/managePasswords 2) Observe error in the console.
,
Jul 28 2016
,
Jul 28 2016
Fix is in the CQ, https://codereview.chromium.org/2188063003.
,
Jul 28 2016
,
Jul 28 2016
Argh, I didn't realise this one existed. It's frustrating that Closure didn't help us find this before the change landed.
,
Jul 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36579b0bc9520e57ed45539d3f82d668d9c2dc2b commit 36579b0bc9520e57ed45539d3f82d668d9c2dc2b Author: dpapad <dpapad@chromium.org> Date: Thu Jul 28 23:55:32 2016 MD Settings: Fix runtime error when visiting "manage passwords" page. BUG= 632432 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2188063003 Cr-Commit-Position: refs/heads/master@{#408513} [modify] https://crrev.com/36579b0bc9520e57ed45539d3f82d668d9c2dc2b/chrome/browser/resources/settings/settings_page/settings_subpage_search.js
,
Jul 29 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dpa...@chromium.org
, Jul 28 2016