New issue
Advanced search Search tips

Issue 632429 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

CRAS a little crashy on 52/53

Project Member Reported by dgreid@chromium.org, Jul 28 2016

Issue description

https://crash.corp.google.com/browse?q=product.name=%27ChromeOS%27%20AND%20product.version=%278350.60.0%27%20AND%20exec_name=%27cras%27

Seems like a lot of crashes on 52, about 10x the normal crash rate.  Not a lot of data on 53 yet, but it doesn't look to be any better.


Any ideas?
 
Owner: hychao@chromium.org
Status: Assigned (was: Untriaged)
The most dominant crashes are:

	cras_tm_call_callbacks-c15fb7e9          53.85%
	profile_switch_delay_cb-2d4746a0         33.33%

This seems to be
https://chromium-review.googlesource.com/344123
which add a cras_tm_create_timer which calls profile_switch_delay_cb.

Another CL in R52 related to profile switch might be related too:
https://chromium-review.googlesource.com/354793

Other crashes are similar to R51 and far less than above two.
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 29 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by dgreid@chromium.org, Jul 29 2016

Labels: -M-54 -MovedFrom-53 M-53
We've still got enough time to fix this crash before 53.  Shut up, sheriffbot.
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/9328255777f233fa007da1375edfa3f416a0c231

commit 9328255777f233fa007da1375edfa3f416a0c231
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Tue Aug 02 11:21:45 2016

CRAS: bt_device - Free timer when device destroyed

In some scenario bluetoothd could ask CRAS to reset bt device
objects, when a scheduled timer later access the freed memory
CRAS would crash. This change tries to fix this the crash by
tracking the profile switch timer and free it when device is
going to destroy.

BUG= chromium:632429 
TEST=Manual test with BT headset, switch between A2DP and HFP.

Change-Id: Iabd722ffabc887248a34a93ab3d04c74157f834e
Reviewed-on: https://chromium-review.googlesource.com/365506
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/9328255777f233fa007da1375edfa3f416a0c231/cras/src/server/cras_bt_device.c

Labels: Merge-Request-53

Comment 7 by dimu@chromium.org, Aug 9 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 9 2016

Labels: merge-merged-release-R53-8530.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/e894c9e88a293222a30299c871d63fb86e358cc6

commit e894c9e88a293222a30299c871d63fb86e358cc6
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Tue Aug 02 11:21:45 2016

CRAS: bt_device - Free timer when device destroyed

In some scenario bluetoothd could ask CRAS to reset bt device
objects, when a scheduled timer later access the freed memory
CRAS would crash. This change tries to fix this the crash by
tracking the profile switch timer and free it when device is
going to destroy.

BUG= chromium:632429 
TEST=Manual test with BT headset, switch between A2DP and HFP.

Change-Id: Iabd722ffabc887248a34a93ab3d04c74157f834e
Reviewed-on: https://chromium-review.googlesource.com/365506
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
(cherry picked from commit 9328255777f233fa007da1375edfa3f416a0c231)
Reviewed-on: https://chromium-review.googlesource.com/367303
Tested-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/e894c9e88a293222a30299c871d63fb86e358cc6/cras/src/server/cras_bt_device.c

Will this fix the majority of the crashes showing up on the crash server?
Yes I believe so. Since this timer was added since M52 which corresponds to when the crash started.
I'll watch for one more week to see if the crash still happen.
Project Member

Comment 11 by sheriffbot@chromium.org, Aug 13 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 12 by sheriffbot@chromium.org, Aug 16 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-53
Status: Fixed (was: Started)
I will do the verify work to see if the crash still happen.
Status: Verified (was: Fixed)
Close this as the profile_switch_delay_cb-2d4746a0 crash disappears.
However there's still crash around cras_tm_call_callback, will use a different issue to track.

Sign in to add a comment