CRAS a little crashy on 52/53 |
|||||||||
Issue descriptionhttps://crash.corp.google.com/browse?q=product.name=%27ChromeOS%27%20AND%20product.version=%278350.60.0%27%20AND%20exec_name=%27cras%27 Seems like a lot of crashes on 52, about 10x the normal crash rate. Not a lot of data on 53 yet, but it doesn't look to be any better. Any ideas?
,
Jul 29 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 29 2016
We've still got enough time to fix this crash before 53. Shut up, sheriffbot.
,
Aug 1 2016
,
Aug 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/9328255777f233fa007da1375edfa3f416a0c231 commit 9328255777f233fa007da1375edfa3f416a0c231 Author: Hsin-Yu Chao <hychao@chromium.org> Date: Tue Aug 02 11:21:45 2016 CRAS: bt_device - Free timer when device destroyed In some scenario bluetoothd could ask CRAS to reset bt device objects, when a scheduled timer later access the freed memory CRAS would crash. This change tries to fix this the crash by tracking the profile switch timer and free it when device is going to destroy. BUG= chromium:632429 TEST=Manual test with BT headset, switch between A2DP and HFP. Change-Id: Iabd722ffabc887248a34a93ab3d04c74157f834e Reviewed-on: https://chromium-review.googlesource.com/365506 Commit-Ready: Hsinyu Chao <hychao@chromium.org> Tested-by: Hsinyu Chao <hychao@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> [modify] https://crrev.com/9328255777f233fa007da1375edfa3f416a0c231/cras/src/server/cras_bt_device.c
,
Aug 9 2016
,
Aug 9 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Aug 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/e894c9e88a293222a30299c871d63fb86e358cc6 commit e894c9e88a293222a30299c871d63fb86e358cc6 Author: Hsin-Yu Chao <hychao@chromium.org> Date: Tue Aug 02 11:21:45 2016 CRAS: bt_device - Free timer when device destroyed In some scenario bluetoothd could ask CRAS to reset bt device objects, when a scheduled timer later access the freed memory CRAS would crash. This change tries to fix this the crash by tracking the profile switch timer and free it when device is going to destroy. BUG= chromium:632429 TEST=Manual test with BT headset, switch between A2DP and HFP. Change-Id: Iabd722ffabc887248a34a93ab3d04c74157f834e Reviewed-on: https://chromium-review.googlesource.com/365506 Commit-Ready: Hsinyu Chao <hychao@chromium.org> Tested-by: Hsinyu Chao <hychao@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> (cherry picked from commit 9328255777f233fa007da1375edfa3f416a0c231) Reviewed-on: https://chromium-review.googlesource.com/367303 Tested-by: Dylan Reid <dgreid@chromium.org> [modify] https://crrev.com/e894c9e88a293222a30299c871d63fb86e358cc6/cras/src/server/cras_bt_device.c
,
Aug 9 2016
Will this fix the majority of the crashes showing up on the crash server?
,
Aug 10 2016
Yes I believe so. Since this timer was added since M52 which corresponds to when the crash started. I'll watch for one more week to see if the crash still happen.
,
Aug 13 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 16 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 16 2016
I will do the verify work to see if the crash still happen.
,
Sep 8 2016
Close this as the profile_switch_delay_cb-2d4746a0 crash disappears. However there's still crash around cras_tm_call_callback, will use a different issue to track. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by cychiang@chromium.org
, Jul 29 2016Status: Assigned (was: Untriaged)