New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 632428 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

[arc-intents] Handle navigation arising from redirects

Project Member Reported by kenobi@chromium.org, Jul 28 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a9a30409316fd19af685b1a88ae21b3e51e71c4

commit 5a9a30409316fd19af685b1a88ae21b3e51e71c4
Author: kenobi <kenobi@chromium.org>
Date: Fri Aug 05 20:36:49 2016

[arc-intents] Handle redirects.

- Move intent filtering (via LocalActivityResolver) into
  ArcNavigationThrottle.  Attach an ArcNavigationThrottle to all
  navigations, don't pre-filter them.  This ensures that the intent
  filtering code sees all the URLs in the redirect chain (not just the
  first URL).

- Modify the ArcNavigationThrottle so that it memoizes the action taken
  by a user on an intent disambig.  This avoids repeatedly popping up
  the intent disambig on each link in a redirect
  chain (e.g. www.some-site.com -> www.twitter.com -> twitter.com).

BUG= 632428 

Review-Url: https://codereview.chromium.org/2194523002
Cr-Commit-Position: refs/heads/master@{#410155}

[modify] https://crrev.com/5a9a30409316fd19af685b1a88ae21b3e51e71c4/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/5a9a30409316fd19af685b1a88ae21b3e51e71c4/chrome/browser/chromeos/arc/arc_navigation_throttle.cc
[modify] https://crrev.com/5a9a30409316fd19af685b1a88ae21b3e51e71c4/chrome/browser/chromeos/arc/arc_navigation_throttle.h

Status: Fixed (was: Assigned)
Labels: VerifyIn-54

Comment 4 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55

Comment 5 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 6 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 7 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 8 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 9 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 11 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment